Never break after operator#672
Merged
Merged
Conversation
wvpm
force-pushed
the
never_break_after_operator
branch
2 times, most recently
from
a36b1a1 to
ba43c46
Compare
wvpm
force-pushed
the
never_break_after_operator
branch
from
ba43c46 to
628e6ef
Compare
wvpm
force-pushed
the
never_break_after_operator
branch
from
628e6ef to
a69a8ce
Compare
wvpm
force-pushed
the
never_break_after_operator
branch
from
a69a8ce to
711ca4b
Compare
Member
|
I agree with this, my only complaint is that this PR seems to do a number of things, not all of whom related to the stated task (ex. whatever is going on in main.cpp). Is there a reason it's like that? |
wvpm
force-pushed
the
never_break_after_operator
branch
from
711ca4b to
2866390
Compare
Contributor
Author
|
Merged to dev as I'm not getting any review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Never break after operators.
Operators are the most important signal of what the code does.
They should always be in sight and never at the end of a line like an afterthought.