Add neuralfoil and automatic conversion from obj to yaml#249
Open
1-Bart-1 wants to merge 106 commits into
Open
Add neuralfoil and automatic conversion from obj to yaml#2491-Bart-1 wants to merge 106 commits into
1-Bart-1 wants to merge 106 commits into
Conversation
- neuralfoil: kulfan/neuralfoil symbols now from AirfoilAero. - polars: create_polars from AirfoilAero (read_aero_matrix stays core). - wing_geometry: LEI (t,camber) test rewritten to POLY with coeffs from AirfoilAero.lei_poly_coeffs; asserts refinement interpolates the coeff vectors. The 6 ObjWing-based tests are not repointed: ObjWing built an obj+single-foil XFoil POLAR_MATRICES wing, a converter workflow ObjAdapter does not yet rebuild (obj_to_yaml does per-section NeuralFoil instead). Needs a decision. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Core YAML loader gains POLAR_MATRICES support: wing_airfoils info_dict may carry cl_file_path/cd_file_path/cm_file_path; load_matrix_polar_data reads the three (alpha x delta) matrices via read_aero_matrix. ObjAdapter.obj_to_matrix_yaml slices the mesh for LE/TE (perpendicular_sections), generates one shared airfoil's cl/cd/cm matrices via AirfoilAero.create_polars, and writes the geometry YAML - the convert-then-load replacement for the dropped live ObjWing. Removed tic/toc (Timers) from create_polars. Validated: obj+foil -> yaml -> Wing(yaml) loads POLAR_MATRICES and solves. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add ram_air_matrix_wing() test helper (obj_to_matrix_yaml -> Wing(yaml)) and repoint wake/forwarddiff/results/refinement_validation/plotting to it. kite_geometry: imports split (mesh utils from ObjAdapter, aero_matrix from core); the three ObjWing-internal testsets (radius/gamma_tip/UNCHANGED/obj deform!) are skipped with a redesign TODO since that behavior was intentionally dropped. Numerics of the converted-wing tests still need a full test-env run to confirm (assertions may need tolerance updates). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ups green Verified in the test env: wing_geometry 295/295 (POLY), neuralfoil+polars 27/27 (AirfoilAero), refinement_validation+wake+results+forwarddiff 55/55 (obj+foil -> POLAR_MATRICES -> Wing converter replacement, incl. ForwardDiff). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…d polars - Move neuralfoil/kulfan cross-validation test to lib/AirfoilAero/test/runtests.jl with its own fixture (test/data/test_airfoil.dat = the former midspan foil coords, keeping the hardcoded aerosandbox/neuralfoil reference values valid). AirfoilAero gains [extras]/[targets] so it tests independently (SciML monorepo style). - Remove the kite midspan foil.dat + generated cl/cd/cm foil polars from data/ (regenerated from the .obj); gitignore them. - Remove neuralfoil_benchmark.jl + neuralfoil_polars.jl examples. - Condense multiline inline comments in the yaml loader. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.