Skip to content

[packchk] The command line option '--url' should check the specified URL case-sensitive #2553

Description

@HansSchneebauer

Describe the bug
When specifying the packchk parameter '-u' or '--url' in the command line, the following URL should be checked against URL in the pdsc file in a case-sensitive way. Currently, the comparison is not case-sensitive, and therefore, you might not detect a mistake in the pdsc file. Many web servers are handling URLs case-sensitive, which may cause a download error once a pack is published.

To Reproduce
Steps to reproduce the behavior:

  • check any pack and specify a URL that differs in upper/lower case characters
  • for example, download the Toshiba pack and unzip it into a folder:
wget https://toshiba.semicon-storage.com/content/dam/toshiba-ss-v3/master/en/semiconductor/product/dl/device-family-pack/Toshiba.SmartMCD-TB9M040_DFP.1.0.0.pack

Then, check the pdsc file against an intentionally wrong URL ('...device-family-Pack…' vs. '...device-family-pack…'). packchk will not detect the mistake, but loading the pack with the specified URL will fail on this server.

packchk -u "https://toshiba.semicon-storage.com/content/dam/toshiba-ss-v3/master/en/semiconductor/product/dl/device-family-Pack/" Toshiba.SmartMCD-TB9M040_DFP.pdsc

Expected behavior
The URL comparison should be case-sensitive.

Environment (please complete the following information):

  • packchk.exe
  • Version 1.4.5
  • OS: Windows on x86

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

Status
Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions