feat: [SDK-4728] support disabling location module#1953
Open
fadi-george wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Adds build-time flags to exclude the native OneSignal location module from React Native apps.
Details
Motivation
Apps that do not use
OneSignal.Locationshould be able to avoid linking native location dependencies so iOS and Android builds do not include location-specific modules or permissions.Scope
This PR adds the core SDK support only:
$OneSignalDisableLocation = trueswitches CocoaPods from the aggregateOneSignalXCFrameworkpod to non-location subspecs.OneSignal_disableLocation=trueswitches Gradle from the aggregatecom.onesignal:OneSignalmodule to non-location modules.The runnable no-location demo is intentionally split into the follow-up stacked PR.
Testing
Unit testing
No unit tests were added. This change adjusts native dependency selection and bridge handling, which is covered by manual app build/runtime checks in the stacked demo PR.
Manual testing
OneSignalLocationin the stacked demo.OneSignal.Locationwithout the location dependency.Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor