Does not build with OpenCV 4

[ChristophHaag]

Archlinux ships OpenCV 4 and osvr-core does not build with it.

There are several #ifdefs in the code checking explicitly for OpenCV 2 or 3 and producing an #error for OpenCV 4 but just removing those does not help, apparently the API changed.

osvr-core should either

1. build an appropriate opencv version with osvr-core
2. allow the selection of an opencv installation in a non default path (/opt/...) in cmake It already does that with OpenCV_DIR
3. update to the opencv 4 API

[rpavlik]

Can you set OpenCV_DIR in CMake? That should let you choose the location of the CMake config file to use. (You could also disable building with opencv if you don't need the hdk optical tracker.) In any case, I will have to look and see what they broke in the API ;) thanks for the report!

…

On Tue, Jan 22, 2019, 6:57 AM Christoph Haag ***@***.***> wrote: Archlinux ships OpenCV 4 and osvr-core does not build with it. There are several #ifdefs in the code checking explicitly for OpenCV 2 or 3 and producing an #error for OpenCV 4 but just removing those does not help, apparently the API changed. osvr-core should either 1. build an appropriate opencv version with osvr-core 2. allow the selection of an opencv installation in a non default path (/opt/...) in cmake 3. update to the opencv 4 API — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#596>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADuyWz1qx62SkLVmhP3i5Gze-gkVwtpks5vFwq1gaJpZM4aMnYf> .

[ChristophHaag]

This method was not immediately obvious from the CMakeList.txt but it works. Thanks.

[rpavlik]

Yeah, it's not in the CMake file because it's the standard way built into CMake for config files.

…

On Tue, Jan 22, 2019, 7:26 AM Christoph Haag ***@***.***> wrote: This method was not immediately obvious from the CMakeList.txt but it works. Thanks. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#596 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADuyYlBAIlhqIwhNCyaaforv4nNzq1tks5vFxGSgaJpZM4aMnYf> .

[ChristophHaag]

Updated to make it compile with OpenCV4: ChristophHaag@f693399

I have not tested running this, I mostly just used the suggestions from my IDE. I haven't cared to test whether the code still works with OpenCV3, personally I would just ditch OpenCV2 and OpencV3 support to minimize the maintenance burden.

[rpavlik]

awesome thanks christoph, I will check and merge this soonish.

[isopix]

[(https://aur.archlinux.org/packages/osvr-core-git/)]
it's patched version for OpenCV4. It compiled with OpenCV 4.3 and older gcc. But it won't compile with OpenCV 4.5

[85%] Built target com_osvr_Multiserver Scanning dependencies of target vbtracker-core [ 85%] Building CXX object plugins/videobasedtracker/CMakeFiles/vbtracker-core.dir/BeaconBasedPoseEstimator.cpp.o /mnt/magazyn/archlinux/aur-osvr-core-git/src/osvr-core/plugins/videobasedtracker/BeaconBasedPoseEstimator.cpp: In member function ‘bool osvr::vbtracker::BeaconBasedPoseEstimator::m_pnpransacEstimator(osvr::vbtracker::LedGroup&)’: /mnt/magazyn/archlinux/aur-osvr-core-git/src/osvr-core/plugins/videobasedtracker/BeaconBasedPoseEstimator.cpp:303:14: error: ‘void ransacResult’ has incomplete type 303 | auto ransacResult = cv::solvePnPRansac( | ^~~~~~~~~~~~ make[2]: [plugins/videobasedtracker/CMakeFiles/vbtracker-core.dir/build.make:82: plugins/videobasedtracker/CMakeFiles/vbtracker-core.dir/BeaconBasedPoseEstimator.cpp.o] Error 1 make[1]: [CMakeFiles/Makefile2:2083: plugins/videobasedtracker/CMakeFiles/vbtracker-core.dir/all] Error 2 make: *** [Makefile:171: all] Error