REGCA Documentation + More Function Primitives#404
Conversation
4ce662c to
0d135d9
Compare
|
Looks good to me. |
12e70a8 to
70a0603
Compare
nkoukpaizan
left a comment
There was a problem hiding this comment.
I still have to go through some of the math and related tests. A few preliminary comments.
|
@abirchfield Clear for your review! Adding these primitives has been very helpful for readability and will help when we fine-tune the solver for all models with state-space discretization unilaterally. |
|
@lukelowry, for faster reviews in the future, I suggest you break PRs like this in single-topic PRs. |
|
@pelesh That is my fault. For various reasons, it turned into a general cleanup + a reference for another branch of mine, so I let it grow. I'll do better with the rest! |
1adb7c8 to
1ae271c
Compare
nkoukpaizan
left a comment
There was a problem hiding this comment.
Mostly looks good to me. A few comments on the common math tests. Please try to minimize the number of hard-coded values.
I would like @abirchfield to approve the new model documentations.
|
@nkoukpaizan Complete, I am glad you pushed back on the tests because they are more readable now. Just awaiting @abirchfield |
Description
Draft of
REGCAmachine-like andREECAexciter-like IBR model specification, which relies on new function primitives inCommonMath. Helps standardize the smooth-ization of the common model components and increases readability. These primitives will be used extensively in the upcoming IBR models.@abirchfield @BSzymanowski I needed this for the theory section of the HICSS paper ASAP and realized I could construct most of the noncontinuous features with a
rampfunction primitive. I changed the variable names because the diagram doesn't match my expectations. Let me know what you think, and compare it against any progress you have made on this model, please@nkoukpaizan Enzyme is starting to make sense to me, so I think I made changes correctly. Please check my CommonMath work!
Proposed changes
REGCAModel DocumentationREECAModel DocumentationCommonMathPrimitive functionsrampqrampCommonMathDerived functionsminmaxlinsegclampslewantiwindupIEEESTrefinement using newCommonMath,but also removing the output limiter, which seems to be incorrectly documented in the Power World reference. The functionality appears unclear and inconsistent across different sources. Many do not include it on theIEEEST,so I removed it since it was proving difficult to comply with Enzyme.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
All in preparation for the two IBR models
REGCAandREECA,which I have working implementations for.