fix: stick footer to bottom on short pages (closes #58)#59
Merged
Conversation
Use flex column layout on <main> with min-h-screen so the footer always stays at the bottom of the viewport. On long pages the footer scrolls naturally after the content. - Add flex flex-col to <main className="min-h-screen"> - Add flex-1 w-full to the main content wrapper div Signed-off-by: Ai-chan-0411 (藍) <aoikabu12@gmail.com>
|
@Ai-chan-0411 is attempting to deploy a commit to the osama's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for the pull request! ✅ A maintainer will review this soon. Please be patient while we take a look. 🙌 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
|
After now you can work on the complicated issues only and let the easy ones for the new contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flex flex-colto<main>so the flex container fills the full viewport height (min-h-screen)flex-1 w-fullto the main content wrapper div so it grows to push the footer downThis ensures the footer is always pinned to the bottom of the viewport when there is little content, while still scrolling naturally below the content on longer pages.
Closes #58
Test plan
🤖 Generated with Claude Code