Change to mono search path logic breaks MacOS dll loading

[CptMoore]

The changes introduced in #57 break env variable interpretations on MacOS.

Before we could specify the target assembly relative to the resources directory path and omit additional search paths:

DOORSTOP_TARGET_ASSEMBLY="Mods/ModTek/lib/ModTek.Preloader.dll"

Now it has to be:

DOORSTOP_TARGET_ASSEMBLY="BattleTech.app/Contents/Resources/Mods/ModTek/lib/ModTek.Preloader.dll"
DOORSTOP_MONO_DLL_SEARCH_PATH_OVERRIDE="BattleTech.app/Contents/Resources/Mods/ModTek/lib"

Note that neither Windows nor Linux are affected, its just MacOS.

Our workaround is to add via run.sh a hardcoded prefix to paths in case its Darwin:

    additional_path="BattleTech.app/Contents/Resources"
    DOORSTOP_TARGET_ASSEMBLY="$additional_path/$DOORSTOP_TARGET_ASSEMBLY"
    DOORSTOP_MONO_DLL_SEARCH_PATH_OVERRIDE="$additional_path/$DOORSTOP_MONO_DLL_SEARCH_PATH_OVERRIDE"

---

Additionally, the README does not mention DOORSTOP_MONO_DLL_SEARCH_PATH_OVERRIDE.

[ManlyMarco]

Is this still an issue on master?

[CptMoore]

probably still an issue, we have to wait until a macos user can test it

[EliW]

Hello @CptMoore & @ManlyMarco -- I'm a MacOS user, and 'happy to test' ... because nothing is working for me at the moment.

I was trying to install BEX:T and was going through their install instructions. Which includes ModTek 4.2 in them. But nothing was working. IE: I drop everything into Battletech.app/Contents/Resources/ ... and then updated my Launch Options to use 'run.sh' as mentioned..... and no mods would be loaded at all. No errors, game would just launch like 'normal', no mods in effect.

So I was searching around and found this discussion here, after thinking about upgrading to 4.5 to see if that fixed the issues. Well, installed 4.5, replacing all the files in my setup ... and same issues.

ModTek just isn't loading at all.

So happy to help test stuff out (and be told I did something stupid as well) ;)

[CptMoore]

@EliW your issue is probably another one
there are arm macos users that were successful with unitydoorstop. see BattletechModders/ModTek#247 (comment) . you need to remove the signature from the executable as that is preventing force loading libraries into the program.

this ticket was about using unitydoorstop as is, ModTek already contains various fixes (they might or might not be necessary anymore):

once it works for you, you can use the unitydoorstop' default run.sh (see this repo) and only change to the name of the Battletech executable and the path to modtek' preloader dll inside run.sh. if you have to specify the resources dir prefix' then thats a "bug", if not, the "bug" is not there anymore.