chore(doctor): replace grunt with npm scripts and build to dist

Grunt's tasks were thin wrappers around tsc, npm test and npm pack:

- ts:devsrc                   -> tsc
- ts:devall                   -> tsc -p tsconfig.test.json
- ts:release_build            -> tsc -p tsconfig.release.json
- clean                       -> scripts/clean.js
- watch:ts                    -> tsc --watch
- shell:npm_test              -> npm test
- tslint:build                -> dropped

The lint task was already failing with 6 errors, was not wired into
build, test, prepack or CI, and tslint itself is deprecated; .ts files
here are covered by the repo-wide prettier lint-staged hook instead.
Dropping grunt-tslint also resolves the ERESOLVE that made npm install
in this package require --legacy-peer-deps, so the .npmrc pinning
legacy-peer-deps=true goes away too.

Compilation moves out of the source tree: src/ now builds to dist/ with
declarations, and the test build goes to dist-test/. dist/ sits at the
same depth as src/ did, so the __dirname/../resources lookup in
sys-info is unaffected. package.json main follows the output; types
keeps pointing at the hand-written typings/, which is the package's
public contract and also supplies the global NativeScriptDoctor
namespace the CLI depends on. typings/interfaces.ts becomes a .d.ts so
that it stops emitting an empty JS file and stops dragging rootDir up
to the package root.

istanbul is dropped along with it: nothing consumed the coverage
report, and it is unmaintained.

Grunt read tsconfig.json with grunt.file.readJSON, which does not
resolve "extends", so it compiled with tsc defaults rather than the
repo's compiler options. Running tsc for real surfaces some dead code
that noUnusedLocals rejects, removed here.

Author: edusperoni

packages/doctor/.gitignore

@@ -17,9 +17,6 @@ coverage
 # nyc test coverage
 .nyc_output
 
-# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
-.grunt
-
 # node-waf configuration
 .lock-wscript
 
@@ -64,6 +61,8 @@ test-reports.xml
 
 *.js
 *.js.map
-/src/.d.ts
-.d.ts
 !/*.js
+!/scripts/*.js
+
+/dist/
+/dist-test/

packages/doctor/.npmrc

@@ -2,21 +2,24 @@
   "name": "@nativescript/doctor",
   "version": "2.0.17",
   "description": "Library that helps identifying if the environment can be used for development of {N} apps.",
-  "main": "src/index.js",
+  "main": "dist/index.js",
   "types": "./typings/nativescript-doctor.d.ts",
   "files": [
-    "src/**/*.js",
+    "dist/**/*.js",
+    "dist/**/*.d.ts",
     "resources",
     "typings",
     "CHANGELOG.md",
     "NOTICE.txt"
   ],
   "scripts": {
-    "clean": "npx rimraf node_modules package-lock.json && npm i && grunt clean",
-    "build": "grunt",
-    "build.all": "grunt ts:devall",
-    "prepack": "grunt pack",
-    "test": "istanbul cover ./node_modules/mocha/bin/_mocha -- --recursive",
+    "clean": "npx rimraf node_modules package-lock.json && npm i && npm run clean.build",
+    "clean.build": "node scripts/clean.js",
+    "build": "tsc",
+    "build.all": "tsc -p tsconfig.test.json && node scripts/copy-test-fixtures.js",
+    "dev": "tsc --watch",
+    "prepack": "npm run clean.build && npm test && tsc -p tsconfig.release.json",
+    "test": "npm run build.all && mocha --recursive dist-test/test",
     "changelog": "conventional-changelog -p angular -i CHANGELOG.md -s"
   },
   "repository": {
@@ -51,17 +54,8 @@
     "@types/yauzl": "2.10.3",
     "chai": "5.3.3",
     "conventional-changelog-cli": "^5.0.0",
-    "grunt": "1.6.1",
-    "grunt-contrib-clean": "2.0.1",
-    "grunt-contrib-watch": "1.1.0",
-    "grunt-shell": "4.0.0",
-    "grunt-ts": "6.0.0-beta.22",
-    "grunt-tslint": "5.0.2",
-    "istanbul": "0.4.5",
     "mocha": "11.7.5",
     "rimraf": "6.1.2",
-    "tslint": "6.1.3",
-    "tslint-microsoft-contrib": "6.2.0",
     "typescript": "~5.9.2"
   },
   "dependencies": {

packages/doctor/Gruntfile.js

@@ -0,0 +1,30 @@
+const child_process = require("child_process");
+const fs = require("fs");
+const path = require("path");
+
+const rootDir = path.join(__dirname, "..");
+
+// Older checkouts compiled next to the sources; .gitignore is the source of
+// truth for which files under src/ and test/ are leftover compiler output.
+const result = child_process.spawnSync("git", ["clean", "-Xdf", "src", "test"], {
+	cwd: rootDir,
+	stdio: "inherit",
+});
+
+if (result.error) {
+	throw result.error;
+}
+
+if (result.status !== 0) {
+	throw new Error(`git clean exited with status ${result.status}`);
+}
+
+for (const dir of ["dist", "dist-test", "coverage"]) {
+	fs.rmSync(path.join(rootDir, dir), { recursive: true, force: true });
+}
+
+for (const entry of fs.readdirSync(rootDir)) {
+	if (entry.endsWith(".tgz")) {
+		fs.rmSync(path.join(rootDir, entry));
+	}
+}

packages/doctor/package.json

@@ -0,0 +1,11 @@
+const fs = require("fs");
+const path = require("path");
+
+const rootDir = path.join(__dirname, "..");
+
+// The tests resolve fixtures relative to __dirname, so they have to sit next to
+// the compiled test files rather than in the source tree.
+fs.cpSync(path.join(rootDir, "test"), path.join(rootDir, "dist-test", "test"), {
+	recursive: true,
+	filter: (src) => !src.endsWith(".ts"),
+});

packages/doctor/scripts/clean.js

@@ -658,20 +658,4 @@ export class AndroidToolsInfo implements NativeScriptDoctor.IAndroidToolsInfo {
 		this._cachedRuntimeVersion = runtimeVersion;
 		return runtimeVersion;
 	}
-
-	private getMaxSupportedCompileVersion(
-		config: Partial<NativeScriptDoctor.IProjectDir> & {
-			runtimeVersion?: string;
-		},
-	): number {
-		if (
-			config.runtimeVersion &&
-			semver.lt(semver.coerce(config.runtimeVersion), "6.1.0")
-		) {
-			return 28;
-		}
-		return this.parseAndroidSdkString(
-			_.last(this.getSupportedTargets(config.projectDir).sort()),
-		);
-	}
 }