Skip to content

Commit c409c34

Browse files
committed
show warning when using JSC engine
1 parent 5122d34 commit c409c34

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

build.gradle

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -330,10 +330,6 @@ task copyFilesToProjectTemeplate {
330330
into "$DIST_FRAMEWORK_PATH"
331331
}
332332

333-
ant.propertyfile(file: "$TEST_APP_PATH/gradle.properties") {
334-
entry(key: "ns_engine", value: "V8")
335-
}
336-
337333
copy {
338334
from "$TEST_APP_PATH/gradle-helpers/paths.gradle"
339335
into "$DIST_FRAMEWORK_PATH/gradle-helpers"

test-app/app/build.gradle

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,10 @@ android {
232232
minSdkVersion minSdkVer
233233
targetSdkVersion computeTargetSdkVersion()
234234
ndk {
235+
if (ns_engine == "JSC") {
236+
outLogger.withStyle(Style.Info).println "\t ! JSC engine only ships arm64-v8a and x86_64 prebuilts; " +
237+
"the app will be built for those ABIs only (armeabi-v7a and x86 are excluded)."
238+
}
235239
if (onlyX86) {
236240
// The updated JSC only ships 64-bit libraries, so fall back to
237241
// x86_64 when a single-ABI (emulator) build is requested.

0 commit comments

Comments
 (0)