Fix erroneous MPI_Bcast sizing in autotune.cc and remove O1 optimization cap.#153
Merged
Conversation
Signed-off-by: romerojosh <joshr@nvidia.com>
Signed-off-by: Josh Romero <joshr@nvidia.com>
romerojosh
changed the title
Collaborator
Author
|
/build |
|
🚀 Build workflow triggered! View run |
|
✅ Build workflow passed! View run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a legacy -O1 optimization cap applied to host code compilation. This limitation was driven by historic issues with
autotune.ccsegfaulting at higher optimizations levels. Codex determined it was due to erroneous counts used in anMPI_Bcastoperation in this file, causing an out-of-bounds stack write. At -O1, the stack arrangement made this benign which is why that workaround always worked. This PR finally fixes the issue and enables higher optimization.