Conversation
fccbbc0 to
5b589ab
Compare
5b589ab to
8818afd
Compare
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
fbcc382 to
efba1d8
Compare
00b12d3 to
b06e0b1
Compare
|
Label |
b06e0b1 to
8e95cd7
Compare
|
/ok to test |
3 similar comments
|
/ok to test |
|
/ok to test |
|
/ok to test |
e4cc065 to
62a943a
Compare
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
Re-check After Author Update
Thanks @drew. I reviewed the session-successor and retry commits at current head 0db1fcf6 against the durable feedback ledger and the VM, Docker, Kubernetes, Podman, and performance layers in the RFC 0012 stack. The signed generation, predecessor, and monotonic rotation now prevent an unrelated same-sandbox bearer from taking over an idle boundary, so GATOR-6143f24e-01 is resolved. The bounded critical-only review found one newly introduced upgrade-path Critical.
Action required: @drew, add a fail-closed compatibility path for persisted sandboxes that have no lineage annotations, plus startup and explicit-start regression coverage, then push an updated head.
Blocking findings:
GATOR-0db1fcf6-01: the mandatory lineage read strands every pre-existing lifecycle-managed sandbox after a gateway upgrade.
Carried findings:
- None; all five prior findings are resolved or waived.
Gator metadata
- Validation: Maintainer-authored implementation of accepted RFC 0012 (#2048) for #1737; review remains scoped to PR #2942 while checking compatibility with VM #2945, Docker #2965, Kubernetes #3144, Podman #3230, and performance #3229.
- Docs: no new Fern documentation obligation in this authentication-only delta.
- Checks: Current-head E2E, GPU E2E, Helm Lint, Trivy Changes, and DCO are green; Branch Checks remain pending. Pipeline handoff remains suspended while the Critical is open.
- E2E:
test:e2eis present and the current-headOpenShell / E2Egate is green; no label,/ok to test, or workflow rerun action is needed this cycle. - Head SHA:
0db1fcf68fb61b80288ca75dc0fb7a8526b6bcc5 - Base SHA:
5b9daab9351b1e053f9a5e0ce4c899f5d3f674b0 - Merge base SHA:
5b57f0d1549677c7547862d26ff9491285ea0fbc - Patch ID:
4ee0dd33436f1602aa950752e7e5158af2db202a - Gator payload:
8 - Review mode:
critical_only - Previous reviewed SHA:
6143f24e2a8269403d1cbca108a722059b4e6b34 - Review budget exhausted: yes
- Maintainer decision required: no — this head introduces a Critical that requires an author fix rather than a Warning-bearing convergence decision.
- Reviewer-quality signals: 1 proposal, 1 validated Critical blocker, 0 duplicate-invariant proposals, 0 waived re-raises, 0 unchanged-code proposals, and 0 missing-reproducer downgrades. The ledger records 6 finding-bearing rounds, 5 prior unique findings, and 30 durable repeated-ID occurrences.
- Next state:
gator:in-review
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Maintainer Convergence DecisionThanks @drew. I checked current head Root-cause findings:
Scope growth:
Reviewer-quality signals:
Maintainer action: @drew or @NVIDIA/openshell-maintainers, either implement Gator metadata
|
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Maintainer Convergence DecisionI checked current head Root-cause findings:
Scope growth:
Reviewer-quality signals:
Maintainer action: @drew or @NVIDIA/openshell-maintainers, either implement Gator metadata
|
|
Label |
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Re-check After Maintainer-Author UpdateThanks @drew. I checked your September 14 reply on The bounded critical-only review found no newly introduced Critical defect in the consolidated VM, Docker, Kubernetes, Podman, and performance delta. Disposition: the prior code finding is waived; the promised operator-facing breaking-upgrade documentation remains outstanding. Remaining items:
Action required: @drew, please add that operator documentation and push an updated head. Gator metadata
|
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
…rvisor-primitives Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Re-check After Author UpdateThanks @drew. I checked current head The previously promised breaking-upgrade documentation is still absent from the current Fern/operator docs. Action required: @drew, please document that adopting RFC 0012 requires operators to stop and recreate existing sandboxes, and that missing or partial lineage remains fail-closed, then push an updated head. Blocking findings:
Carried findings:
Gator metadata
|
Summary
Implement RFC 0012 as one combined change. This PR defines the Isolation Backend and adds the OpenShell implementation: the Sandbox Protocol,
OpenShellRuntimeBackend, separateopenshell-supervisorandopenshell-sandboxbinaries, transport-neutral JWT authentication, and the Docker, Podman, Kubernetes, and VM integrations.The supervisor stays outside the agent workload. Each compute driver creates the runtime resources, protected channel, and outer network fence needed by its platform.
Related Issue
Part of #1737. Implements the architecture accepted in #2048.
Changes
openshell-isolation-interfacecrate and backend conformance tests.OpenShellRuntimeBackendand the authenticated OpenShell Sandbox Protocol.Driver placement
network_mode=noneon the workload.Testing
mise run pre-commitChecklist
Consolidated stack
The following stacked PRs are now merged into this PR:
#2941 is superseded by the canonical RFC merged in #2048. #3151 was folded into this PR.