Skip to content

Support BioStructures.Chain with ramachandran#61

Merged
AntonOresten merged 1 commit into
MurrellGroup:mainfrom
timholy:teh/chain
Mar 30, 2026
Merged

Support BioStructures.Chain with ramachandran#61
AntonOresten merged 1 commit into
MurrellGroup:mainfrom
timholy:teh/chain

Conversation

@timholy
Copy link
Copy Markdown
Contributor

@timholy timholy commented Mar 26, 2026

Getting a new release of ProteinChains would also be great! ProteinChain(chain::BioStructures.Chain) is available in the development version but not yet released.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.57%. Comparing base (73a6f9e) to head (5cbccb8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/misc/ramachandran.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   53.74%   53.57%   -0.17%     
==========================================
  Files          13       13              
  Lines         655      657       +2     
==========================================
  Hits          352      352              
- Misses        303      305       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AntonOresten
Copy link
Copy Markdown
Member

Thanks Tim, and sorry about the delay!

RE ProteinChains: are you on ProteinChains v0.7?
image
I'm not sure what you mean. I can see the method dating back to at least v0.7.0:
https://github.com/MurrellGroup/ProteinChains.jl/blob/79319f660fc2f399e4e33aa4ded1e49becbd18a6/src/io/read.jl#L26

@AntonOresten AntonOresten changed the title Support Chain with ramachandran Support BioStructures.Chain with ramachandran Mar 30, 2026
@AntonOresten AntonOresten merged commit 2164b5c into MurrellGroup:main Mar 30, 2026
2 of 4 checks passed
@timholy timholy deleted the teh/chain branch March 31, 2026 10:39
@timholy
Copy link
Copy Markdown
Contributor Author

timholy commented Mar 31, 2026

I must have had an old version installed. Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants