MXTS-74974: address PR review feedback (artifact-registry plugin 2.2.5, commit lockfile, explicit sourcesJar/javadocJar ordering)

Author: mxt-mischa

microdocs-crawler-gradle/build.gradle

@@ -54,18 +54,19 @@ task javadocJar(type: Jar, dependsOn: javadoc) {
   from 'build/docs/javadoc'
 }
 
-// sourcesJar is created automatically by withSourcesJar() below (via the
-// com.maxxton.convention plugin's PublishingConfiguration, which calls it
-// as soon as maven-publish is applied).
+// Registers the sourcesJar task (withJavadocJar() just attaches the
+// existing javadocJar task above). Declared before the artifacts{} block
+// below so both tasks are guaranteed to exist by the time it references
+// them, rather than relying on the com.maxxton.convention plugin having
+// already created sourcesJar earlier via PublishingConfiguration.
+java {
+  withJavadocJar()
+  withSourcesJar()
+}
 
 artifacts {
   archives fatJar
 
   archives javadocJar
   archives sourcesJar
 }
-
-java {
-  withJavadocJar()
-  withSourcesJar()
-}

microdocs-crawler-gradle/gradle.lockfile

@@ -0,0 +1,17 @@
+# This is a Gradle generated file for dependency locking.
+# Manual edits can break the build and are not advised.
+# This file is expected to be part of source control.
+com.fasterxml.jackson.core:jackson-annotations:2.10.1=compileClasspath,integrationTestCompileClasspath,integrationTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+com.fasterxml.jackson.core:jackson-core:2.10.1=compileClasspath,integrationTestCompileClasspath,integrationTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+com.fasterxml.jackson.core:jackson-databind:2.10.1=compileClasspath,integrationTestCompileClasspath,integrationTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+com.mashape.unirest:unirest-java:1.4.9=compileClasspath,integrationTestCompileClasspath,integrationTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+com.maxxton:microdocs-core-java:3.0.0=compileClasspath,integrationTestCompileClasspath,integrationTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+commons-codec:commons-codec:1.9=compileClasspath,integrationTestCompileClasspath,integrationTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+commons-logging:commons-logging:1.2=compileClasspath,integrationTestCompileClasspath,integrationTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.apache.httpcomponents:httpasyncclient:4.1.1=compileClasspath,integrationTestCompileClasspath,integrationTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.apache.httpcomponents:httpclient:4.5.2=compileClasspath,integrationTestCompileClasspath,integrationTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.apache.httpcomponents:httpcore-nio:4.4.4=compileClasspath,integrationTestCompileClasspath,integrationTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.apache.httpcomponents:httpcore:4.4.4=compileClasspath,integrationTestCompileClasspath,integrationTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.apache.httpcomponents:httpmime:4.5.2=compileClasspath,integrationTestCompileClasspath,integrationTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.json:json:20160212=compileClasspath,integrationTestCompileClasspath,integrationTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+empty=annotationProcessor,integrationTestAnnotationProcessor,testAnnotationProcessor

microdocs-crawler-gradle/settings.gradle

@@ -7,7 +7,7 @@ pluginManagement {
     gradlePluginPortal()
   }
   plugins {
-    id("com.google.cloud.artifactregistry.gradle.plugin") version "2.2.0"
+    id("com.google.cloud.artifactregistry.gradle.plugin") version "2.2.5"
   }
 }
 
@@ -16,7 +16,7 @@ buildscript {
     gradlePluginPortal()
   }
   dependencies {
-    classpath("com.google.cloud.artifactregistry.gradle-plugin:com.google.cloud.artifactregistry.gradle-plugin.gradle.plugin:2.2.0")
+    classpath("com.google.cloud.artifactregistry.gradle-plugin:com.google.cloud.artifactregistry.gradle-plugin.gradle.plugin:2.2.5")
   }
 }