From c5361aa6a544c7fdb6b863586da9bcdb65d806ee Mon Sep 17 00:00:00 2001 From: rocky Date: Wed, 10 Jun 2026 06:54:51 -0400 Subject: [PATCH 1/6] Trace sympy.rsolve --- .github/workflows/windows.yml | 4 ++-- mathics/builtin/recurrence.py | 7 +++++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index b190932ae..df8a9f124 100755 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -54,8 +54,8 @@ jobs: # we needs some CI that tests running when packages aren't available # So "dev" only below, not "dev,full". run: | - # The below pytest is hanging (not failing) on Windows. This is probably. + # The below pytest is hanging (not failing) on Windows. # So remove for now # make pytest gstest - make doctest DOCTEST_OPTIONS="--exclude WordCloud" + python3 mathics/docpipeline.py --exclude WordCloud # make check diff --git a/mathics/builtin/recurrence.py b/mathics/builtin/recurrence.py index fe282e623..484e354ca 100644 --- a/mathics/builtin/recurrence.py +++ b/mathics/builtin/recurrence.py @@ -5,6 +5,7 @@ """ import sympy +import mathics.eval.tracing as tracing from mathics.core.atoms import IntegerM1 from mathics.core.attributes import A_CONSTANT from mathics.core.builtin import Builtin @@ -153,9 +154,11 @@ def is_relation(eqn): # Sympy raises error when given empty conditions. Fixed in # upcoming sympy release. if sym_conds != {}: - sym_result = sympy.rsolve(sym_eq, sym_func, sym_conds) + sym_result = tracing.run_sympy( + sympy.rsolve, sym_eq, sym_func, sym_conds + ) else: - sym_result = sympy.rsolve(sym_eq, sym_func) + sym_result = tracing.run_sympy(sympy.rsolve, sym_eq, sym_func) if not isinstance(sym_result, list): sym_result = [sym_result] From 13bd5474c6d2eef9894907c032b917d1ab10f459 Mon Sep 17 00:00:00 2001 From: rocky Date: Wed, 10 Jun 2026 18:05:32 -0400 Subject: [PATCH 2/6] Another attempt to get Windows CI working --- .github/workflows/windows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index df8a9f124..c27e49f58 100755 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -44,7 +44,7 @@ jobs: python -m pip install setuptools wheel - name: Install Mathics3 with full dependencies run: | - make develop-full + make develop - name: Test Mathics3 # Limit pip install to a basic install *without* full dependencies. # Here is why: From 0df7b15409bf9d39ff6b41bb7467120528917a37 Mon Sep 17 00:00:00 2001 From: rocky Date: Wed, 10 Jun 2026 18:09:47 -0400 Subject: [PATCH 3/6] Try Windows CI with 3.13 instead of 3.14 --- .github/workflows/windows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index c27e49f58..18eb285cc 100755 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -15,7 +15,7 @@ jobs: os: [windows] # "make doctest" on MS Windows fails without showing much of a # trace of where things went wrong on Python before 3.11. - python-version: ['3.14'] + python-version: ['3.13'] steps: - uses: actions/checkout@v6 - name: Set up Python ${{ matrix.python-version }} From b776c632bd68d95c262c0158a6818f8e561855bb Mon Sep 17 00:00:00 2001 From: rocky Date: Wed, 10 Jun 2026 18:22:43 -0400 Subject: [PATCH 4/6] Another attempt to get Windows CI working --- .github/workflows/windows.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 18eb285cc..821ce96ed 100755 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -16,6 +16,11 @@ jobs: # "make doctest" on MS Windows fails without showing much of a # trace of where things went wrong on Python before 3.11. python-version: ['3.13'] + + # Setting the environment variable globally for all steps in this job + env: + MATHICS_CHARACTER_ENCODING: "ASCII" + steps: - uses: actions/checkout@v6 - name: Set up Python ${{ matrix.python-version }} @@ -57,5 +62,6 @@ jobs: # The below pytest is hanging (not failing) on Windows. # So remove for now # make pytest gstest - python3 mathics/docpipeline.py --exclude WordCloud + python3 -m pytest test + # python3 mathics/docpipeline.py --exclude WordCloud # make check From ea1853bdff67dc042848518dcb641d69e1029a8c Mon Sep 17 00:00:00 2001 From: rocky Date: Wed, 10 Jun 2026 18:32:58 -0400 Subject: [PATCH 5/6] Another attempt to get Windows CI working --- .github/workflows/windows.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 821ce96ed..bb3188b27 100755 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -15,7 +15,7 @@ jobs: os: [windows] # "make doctest" on MS Windows fails without showing much of a # trace of where things went wrong on Python before 3.11. - python-version: ['3.13'] + python-version: ['3.14'] # Setting the environment variable globally for all steps in this job env: @@ -37,6 +37,8 @@ jobs: # choco install --force llvm # choco install tesseract set LLVM_DIR="C:\Program Files\LLVM" + - name: Install GNU Make + run: choco install make - name: Install Mathics3 with Python dependencies run: | pip install pyocr # from full @@ -47,7 +49,7 @@ jobs: # bash -x admin-tools/make-JSON-tables.sh # cd .. python -m pip install setuptools wheel - - name: Install Mathics3 with full dependencies + - name: Install Mathics3 run: | make develop - name: Test Mathics3 @@ -58,10 +60,8 @@ jobs: # * Other CI tests on other (faster) OS's full dependencies and # we needs some CI that tests running when packages aren't available # So "dev" only below, not "dev,full". + shell: bash run: | - # The below pytest is hanging (not failing) on Windows. - # So remove for now - # make pytest gstest - python3 -m pytest test - # python3 mathics/docpipeline.py --exclude WordCloud + make pytest gstest + make doctest DOCTEST_OPTIONS="--exclude WordCloud" # make check From 0afd0df5e970aa438ed9c42a098098e1aa6cd48f Mon Sep 17 00:00:00 2001 From: rocky Date: Wed, 10 Jun 2026 18:41:19 -0400 Subject: [PATCH 6/6] Comment out Windows testing right now. Windows CI testing has been hanging without any indication of what is hanging. We've tried with a bash shell rather than powershell, Using GNU Make and not (running Python commands directly), using to Python 3.13 instead of 3.14. Nothing seems to work or indicate what is hanging. So remove testing for now. If there is a Windows user who is interested, that person can scope out what is failing. --- .github/workflows/windows.yml | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index bb3188b27..ba544a528 100755 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -52,16 +52,16 @@ jobs: - name: Install Mathics3 run: | make develop - - name: Test Mathics3 - # Limit pip install to a basic install *without* full dependencies. - # Here is why: - # * Windows is the slowest CI build, this speeds up testing by about - # 3 minutes - # * Other CI tests on other (faster) OS's full dependencies and - # we needs some CI that tests running when packages aren't available - # So "dev" only below, not "dev,full". - shell: bash - run: | - make pytest gstest - make doctest DOCTEST_OPTIONS="--exclude WordCloud" - # make check + # - name: Test Mathics3 + # # Limit pip install to a basic install *without* full dependencies. + # # Here is why: + # # * Windows is the slowest CI build, this speeds up testing by about + # # 3 minutes + # # * Other CI tests on other (faster) OS's full dependencies and + # # we needs some CI that tests running when packages aren't available + # # So "dev" only below, not "dev,full". + # shell: bash + # run: | + # make pytest gstest + # make doctest DOCTEST_OPTIONS="--exclude WordCloud" + # # make check