tests failing because cython not installed

[jswhit]

the v1.3.1rel builds are failing with:

not running tst_unicode3.py ...
Traceback (most recent call last):
File "run_all.py", line 45, in
import numpy, cython
ImportError: No module named cython

[matthew-brett]

Do the tests need Cython?

[matthew-brett]

Ah no - I see - you assume the tests are being run on the same machine that built netcdf4-python, and you want to print out the Cython version. Maybe that could be guarded with a try ... except ImportError clause in run_all.py. But in the meantime, I've added Cython to the test dependencies.

[jswhit]

Cython really only should be needed for building - so I guess that's a bug in the tests.

[matthew-brett]

Seems like a real test failure for 32-bit builds, affecting 32-bit Linux builds, and dual-arch Mac builds.

Traceback (most recent call last):

  File "/Users/travis/build/MacPython/netcdf4-python-wheels/tmp_for_test/tst_cdf5.py", line 17, in setUp

    d = nc.createDimension('dim',dimsize) # 64-bit dimension

  File "netCDF4/_netCDF4.pyx", line 2231, in netCDF4._netCDF4.Dataset.createDimension

  File "netCDF4/_netCDF4.pyx", line 2952, in netCDF4._netCDF4.Dimension.__init__

OverflowError: long int too large to convert

[jswhit]

Hmm. I guess we will have to check whether the platform is 64 or 32 bit and skip that test on 32 bit platforms. Something like this perhaps:

…

--- a/test/run_all.py +++ b/test/run_all.py @@ -1,4 +1,4 @@ -import glob, os, sys, unittest +import glob, os, sys, unittest, struct from netCDF4 import getlibversion,__hdf5libversion__,__netcdf4libversion__,__version__ from netCDF4 import __has_cdf5_format__, __has_nc_inq_path__, __has_nc_par__ @@ -21,7 +21,7 @@ if __netcdf4libversion__ < '4.2.1' or __has_nc_par__: if not __has_nc_inq_path__: test_files.remove('tst_filepath.py') sys.stdout.write('not running tst_filepath.py ...\n') -if not __has_cdf5_format__: +if not __has_cdf5_format__ or struct.calcsize("P") < 8: test_files.remove('tst_cdf5.py') sys.stdout.write('not running tst_cdf5.py ...\n') The odd thing is that test was there in the 1.3.0 release also. I'll delete and re-create the tag with this patch added.

-Jeff

On Tue, Oct 31, 2017 at 12:48 AM, Matthew Brett ***@***.***> wrote: Seems like a real test failure for 32-bit builds, affecting 32-bit Linux builds, and dual-arch Mac builds. Traceback (most recent call last): File "/Users/travis/build/MacPython/netcdf4-python-wheels/tmp_for_test/tst_cdf5.py", line 17, in setUp d = nc.createDimension('dim',dimsize) # 64-bit dimension File "netCDF4/_netCDF4.pyx", line 2231, in netCDF4._netCDF4.Dataset.createDimension File "netCDF4/_netCDF4.pyx", line 2952, in netCDF4._netCDF4.Dimension.__init__ OverflowError: long int too large to convert — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjYCZcERpBjtHzX9RzRv69C4iQ1inC9ks5sxsLCgaJpZM4QLyyM> .

-- Jeffrey S. Whitaker NOAA/OAR/PSD R/PSD1 325 Broadway, Boulder, CO, 80305-3328 Phone: (303)497-6313 FAX: (303)497-6449