Share Data: add spacing between preference rows - #30
Open
ps2 wants to merge 1 commit into
Open
Conversation
With the CheckmarkListItem Liquid Glass fix (LoopKit #603) removing the per-row button backgrounds that used to give implicit separation, the three options sat too close together. Give the chooser VStack explicit 24pt spacing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 24pt spacing between the three options on the Share Data (usage-data preference) screen.
With LoopKit #603 (opt out of iOS 26 Liquid Glass button styling on
CheckmarkListItem), the per-row button backgrounds that previously gave implicit separation are gone, so the options were cramped. This gives the chooserVStackexplicitspacing: 24.Pairs with LoopKit#603; verified on-device (next-dev, iPhone 16 Pro).