fix: applying some copilot suggestions

Author: lachlangrose

loopstructural/gui/map2loop_tools/basal_contacts_widget.py

@@ -152,10 +152,7 @@ def _setup_field_combo_boxes(self):
             self.unitNameFieldComboBox.setLayer(geology)
         else:
             # Ensure combo boxes are cleared if no geology layer selected
-            try:
-                self.unitNameFieldComboBox.setLayer(None)
-            except Exception:
-                pass
+            self.unitNameFieldComboBox.setLayer(None)
 
     def _on_geology_layer_changed(self):
         """Update field combo boxes when geology layer changes."""

loopstructural/gui/map2loop_tools/fault_topology_widget.py

@@ -5,6 +5,7 @@
 import geopandas as gpd
 from PyQt5.QtWidgets import QDialog, QMessageBox
 from qgis.PyQt import uic
+from qgis.core import QgsMapLayerProxyModel
 
 
 class FaultTopologyWidget(QDialog):
@@ -41,13 +42,9 @@ def __init__(self, parent=None, data_manager=None):
         ui_path = os.path.join(os.path.dirname(__file__), "fault_topology_widget.ui")
         uic.loadUi(ui_path, self)
         # Set filter for fault layer selection
-        try:
-            from qgis.core import QgsMapLayerProxyModel
 
-            self.faultLayerComboBox.setFilters(QgsMapLayerProxyModel.LineLayer)
-            self.faultLayerComboBox.layerChanged.connect(self._on_fault_layer_changed)
-        except Exception:
-            pass
+        self.faultLayerComboBox.setFilters(QgsMapLayerProxyModel.LineLayer)
+        self.faultLayerComboBox.layerChanged.connect(self._on_fault_layer_changed)
         self.runButton.clicked.connect(self._run_topology)
         self._guess_fault_layer_and_field()
 

loopstructural/gui/map2loop_tools/sampler_widget.py

@@ -70,13 +70,10 @@ def _export_layer_for_debug(self, layer, name_prefix: str):
 
         except Exception as err:
             if getattr(self, '_debug', None):
-                try:
-                    self._debug.plugin.log(
-                        message=f"[map2loop] Failed to export layer '{name_prefix}': {err}",
-                        log_level=2,
-                    )
-                except Exception:
-                    pass
+                self._debug.plugin.log(
+                    message=f"[map2loop] Failed to export layer '{name_prefix}': {err}",
+                    log_level=2,
+                )
         return None
 
     def _serialize_layer(self, layer, name_prefix: str):

loopstructural/gui/map2loop_tools/sorter_widget.py

@@ -4,6 +4,8 @@
 
 from PyQt5.QtWidgets import QMessageBox, QWidget
 from qgis.core import QgsRasterLayer
+from qgis.core import QgsMapLayerProxyModel
+
 from qgis.PyQt import uic
 
 from loopstructural.main.helpers import get_layer_names
@@ -39,16 +41,11 @@ def __init__(self, parent=None, data_manager=None, debug_manager=None):
         uic.loadUi(ui_path, self)
 
         # Configure layer filters programmatically (avoid QGIS enums in UI)
-        try:
-            from qgis.core import QgsMapLayerProxyModel
 
-            self.geologyLayerComboBox.setFilters(QgsMapLayerProxyModel.PolygonLayer)
-            self.contactsLayerComboBox.setFilters(QgsMapLayerProxyModel.LineLayer)
-            self.structureLayerComboBox.setFilters(QgsMapLayerProxyModel.PointLayer)
-            self.dtmLayerComboBox.setFilters(QgsMapLayerProxyModel.RasterLayer)
-            # preserve allowEmptyLayer where UI set it
-        except Exception:
-            pass
+        self.geologyLayerComboBox.setFilters(QgsMapLayerProxyModel.PolygonLayer)
+        self.contactsLayerComboBox.setFilters(QgsMapLayerProxyModel.LineLayer)
+        self.structureLayerComboBox.setFilters(QgsMapLayerProxyModel.PointLayer)
+        self.dtmLayerComboBox.setFilters(QgsMapLayerProxyModel.RasterLayer)
 
         # Initialize sorting algorithms
         self.sorting_algorithms = list(SORTER_LIST.keys())
@@ -118,13 +115,10 @@ def _serialize_params_for_logging(self, params, context_label: str):
 
     def _log_params(self, context_label: str):
         if getattr(self, "_debug", None):
-            try:
-                self._debug.log_params(
-                    context_label=context_label,
-                    params=self._serialize_params_for_logging(self.get_parameters(), context_label),
-                )
-            except Exception:
-                pass
+            self._debug.log_params(
+                context_label=context_label,
+                params=self._serialize_params_for_logging(self.get_parameters(), context_label),
+            )
 
     def _guess_layers(self):
         """Automatically detect and set appropriate field names using ColumnMatcher."""

loopstructural/gui/map2loop_tools/thickness_calculator_widget.py

@@ -4,6 +4,8 @@
 
 from PyQt5.QtWidgets import QLabel, QMessageBox, QWidget
 from qgis.PyQt import uic
+from qgis.core import QgsMapLayerProxyModel
+
 
 from loopstructural.toolbelt.preferences import PlgOptionsManager
 
@@ -37,16 +39,12 @@ def __init__(self, parent=None, data_manager=None, debug_manager=None):
         uic.loadUi(ui_path, self)
 
         # Configure layer filters programmatically (avoid enum values in .ui)
-        try:
-            from qgis.core import QgsMapLayerProxyModel
 
-            self.dtmLayerComboBox.setFilters(QgsMapLayerProxyModel.RasterLayer)
-            self.geologyLayerComboBox.setFilters(QgsMapLayerProxyModel.PolygonLayer)
-            self.basalContactsComboBox.setFilters(QgsMapLayerProxyModel.LineLayer)
-            self.sampledContactsComboBox.setFilters(QgsMapLayerProxyModel.PointLayer)
-            self.structureLayerComboBox.setFilters(QgsMapLayerProxyModel.PointLayer)
-        except Exception:
-            pass
+        self.dtmLayerComboBox.setFilters(QgsMapLayerProxyModel.RasterLayer)
+        self.geologyLayerComboBox.setFilters(QgsMapLayerProxyModel.PolygonLayer)
+        self.basalContactsComboBox.setFilters(QgsMapLayerProxyModel.LineLayer)
+        self.sampledContactsComboBox.setFilters(QgsMapLayerProxyModel.PointLayer)
+        self.structureLayerComboBox.setFilters(QgsMapLayerProxyModel.PointLayer)
 
         # Initialize calculator types
         self.calculator_types = ["InterpolatedStructure", "StructuralPoint"]
@@ -111,12 +109,9 @@ def _serialize_params_for_logging(self, params, context_label: str):
 
     def _log_params(self, context_label: str, params=None):
         if getattr(self, "_debug", None):
-            try:
-                payload = params if params is not None else self.get_parameters()
-                payload = self._serialize_params_for_logging(payload, context_label)
-                self._debug.log_params(context_label=context_label, params=payload)
-            except Exception:
-                pass
+            payload = params if params is not None else self.get_parameters()
+            payload = self._serialize_params_for_logging(payload, context_label)
+            self._debug.log_params(context_label=context_label, params=payload)
 
     def _guess_layers(self):
         """Attempt to auto-select layers based on common naming conventions."""

loopstructural/gui/map2loop_tools/user_defined_sorter_widget.py

@@ -1,6 +1,5 @@
 """Widget for user-defined stratigraphic column."""
 
-
 from typing import Any
 from PyQt5.QtWidgets import QMessageBox, QVBoxLayout, QWidget
 
@@ -58,10 +57,7 @@ def set_debug_manager(self, debug_manager):
 
     def _log_params(self, context_label: str, params: Any):
         if getattr(self, "_debug", None):
-            try:
-                self._debug.log_params(context_label=context_label, params=params)
-            except Exception:
-                pass
+            self._debug.log_params(context_label=context_label, params=params)
 
     def _run_sorter(self):
         """Run the user-defined stratigraphic sorter algorithm.

loopstructural/gui/modelling/geological_model_tab/feature_details_panel.py

@@ -126,6 +126,7 @@ def __init__(self, parent=None, *, feature=None, model_manager=None, data_manage
         group_box.setLayout(form_layout)
         self.layout.addWidget(group_box)
         self.layout.addWidget(table_group_box)
+        # this will call the addMidBlock and addExportBlock methods
         self.addMidBlock()
         self.addExportBlock()
 

loopstructural/gui/modelling/geological_model_tab/geological_model_tab.py

@@ -51,7 +51,7 @@ def __init__(self, parent=None, *, model_manager=None, data_manager=None):
                 try:
                     self.model_manager.observers.append(self.update_feature_list)
                 except Exception:
-                    pass
+                    raise RuntimeError("Failed to register model update observer")
         # Main layout
         mainLayout = QVBoxLayout(self)
 
@@ -169,8 +169,8 @@ def _on_finished():
                     for obs in getattr(self.model_manager, 'observers', []):
                         try:
                             obs()
-                        except Exception:
-                            pass
+                        except Exception as e:
+                            self._debug.log_error("Error notifying observer", e)
             finally:
                 try:
                     progress.close()
@@ -282,7 +282,6 @@ def _on_model_update_started(self):
 
     def _on_model_update_finished(self):
         """Close the progress dialog shown for model updates."""
-        print("Model update finished - closing progress dialog")
         try:
             if getattr(self, '_progress_dialog', None) is not None:
                 try:

loopstructural/main/m2l_api.py

@@ -374,7 +374,6 @@ def sample_contacts(
     except Exception as e:
         print("Failed to save sampler debug info")
         print(e)
-        pass
 
     return samples
 

loopstructural/main/vectorLayerWrapper.py

@@ -825,8 +825,8 @@ def _infer_wkb(series):
                 # z?
                 try:
                     has_z = has_z or bool(getattr(geom, "has_z", False))
-                except Exception:
-                    pass
+                except Exception as e:
+                    print("Error checking geometry Z value", e)
                 if base:
                     break
 
@@ -858,7 +858,8 @@ def _infer_wkb(series):
                 epsg = geodataframe.crs.to_epsg()
                 if epsg:
                     crs = QgsCoordinateReferenceSystem.fromEpsgId(int(epsg))
-            except Exception:
+            except Exception as e:
+                print("Error building CRS from EPSG", e)
                 pass
 
     # --- Build QGIS fields from pandas dtypes
@@ -920,6 +921,7 @@ def _qvariant_type(dtype) -> QVariant.Type:
                 try:
                     val = val.item()
                 except Exception:
+                    # don't crash UI on conversion failure
                     pass
             if pd.api.types.is_datetime64_any_dtype(geodataframe[col].dtype):
                 if pd.isna(val):