From 2b062b724c6472ad75dd85ea041e27e3bb695617 Mon Sep 17 00:00:00 2001
From: Sushobhit Dua <38429226+sushobhit-lt@users.noreply.github.com>
Date: Thu, 30 Apr 2026 13:36:46 +0530
Subject: [PATCH] fix(TE-4324): read testName from caps with name fallback

LSRS returns the test name under two different keys depending on the
resolution path:
  - SessionInfo (Redis-success): `testName`
  - LTMS-fallback response: `name`

The earlier fix only read `.name`, so the primary Redis-success path
silently dropped the value. Read `testName` first with `name` as
fallback in both server.ts (3 caps-resolution branches) and
processSnapshot.ts (2 sessionCapabilitiesMap lookups).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 src/lib/processSnapshot.ts | 10 ++++++----
 src/lib/server.ts          | 18 ++++++++++--------
 2 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/src/lib/processSnapshot.ts b/src/lib/processSnapshot.ts
index 1b697c4..1b2c894 100644
--- a/src/lib/processSnapshot.ts
+++ b/src/lib/processSnapshot.ts
@@ -95,8 +95,9 @@ export async function prepareSnapshot(snapshot: Snapshot, ctx: Context): Promise
                 processedOptions.testName = ctx.testIdTestNameMap.get(processedOptions.testId);
             } else if (ctx.sessionCapabilitiesMap && ctx.sessionCapabilitiesMap.has(sessionId)) {
                 const sessionCapabilities = ctx.sessionCapabilitiesMap.get(sessionId);
-                if (sessionCapabilities && sessionCapabilities.name) {
-                    processedOptions.testName = sessionCapabilities.name;
+                const sessionTestName = sessionCapabilities?.testName || sessionCapabilities?.name;
+                if (sessionTestName) {
+                    processedOptions.testName = sessionTestName;
                 }
             }
         }
@@ -594,8 +595,9 @@ export default async function processSnapshot(snapshot: Snapshot, ctx: Context):
                 processedOptions.testName = ctx.testIdTestNameMap.get(processedOptions.testId);
             } else if (ctx.sessionCapabilitiesMap && ctx.sessionCapabilitiesMap.has(sessionId)) {
                 const sessionCapabilities = ctx.sessionCapabilitiesMap.get(sessionId);
-                if (sessionCapabilities && sessionCapabilities.name) {
-                    processedOptions.testName = sessionCapabilities.name;
+                const sessionTestName = sessionCapabilities?.testName || sessionCapabilities?.name;
+                if (sessionTestName) {
+                    processedOptions.testName = sessionTestName;
                 }
             }
         }
diff --git a/src/lib/server.ts b/src/lib/server.ts
index 6aff699..7f58e5c 100644
--- a/src/lib/server.ts
+++ b/src/lib/server.ts
@@ -107,10 +107,11 @@ export default async (ctx: Context): Promise<FastifyInstance<Server, IncomingMes
 					// Use cached capabilities if available
 					const cachedCapabilities = ctx.sessionCapabilitiesMap.get(sessionId);
 					capsBuildId = cachedCapabilities?.buildId || ''
-					if (cachedCapabilities?.name) {
-						snapshot.options.testName = cachedCapabilities.name;
+					const cachedTestName = cachedCapabilities?.testName || cachedCapabilities?.name;
+					if (cachedTestName) {
+						snapshot.options.testName = cachedTestName;
 						if (cachedCapabilities?.id) {
-							ctx.testIdTestNameMap?.set(cachedCapabilities.id, cachedCapabilities.name);
+							ctx.testIdTestNameMap?.set(cachedCapabilities.id, cachedTestName);
 						}
 					}
 				} else {
@@ -119,11 +120,12 @@ export default async (ctx: Context): Promise<FastifyInstance<Server, IncomingMes
 						let fetchedCapabilitiesResp = await ctx.client.getSmartUICapabilities(sessionId, ctx.config, ctx.git, ctx.log, ctx.isStartExec, ctx.options.baselineBuild, ctx.env);
 						capsBuildId = fetchedCapabilitiesResp?.buildId || ''
 						ctx.log.debug(`fetch caps for sessionId: ${sessionId} are ${JSON.stringify(fetchedCapabilitiesResp)}`)
-						if (fetchedCapabilitiesResp?.name) {
-							snapshot.options.testName = fetchedCapabilitiesResp.name;
+						const fetchedTestName = fetchedCapabilitiesResp?.testName || fetchedCapabilitiesResp?.name;
+						if (fetchedTestName) {
+							snapshot.options.testName = fetchedTestName;
 							const testIdForCache = fetchedCapabilitiesResp?.id || fetchedCapabilitiesResp?.testId;
 							if (testIdForCache) {
-								ctx.testIdTestNameMap?.set(testIdForCache, fetchedCapabilitiesResp.name);
+								ctx.testIdTestNameMap?.set(testIdForCache, fetchedTestName);
 							}
 						}
 						if (capsBuildId) {
@@ -134,8 +136,8 @@ export default async (ctx: Context): Promise<FastifyInstance<Server, IncomingMes
 							// LTMS fallback: only testId returned, no buildId
 							ctx.sessionTestIdMap?.set(sessionId, fetchedCapabilitiesResp.testId);
 							snapshot.options.testId = fetchedCapabilitiesResp.testId;
-							if (fetchedCapabilitiesResp?.name) {
-								ctx.testIdTestNameMap?.set(fetchedCapabilitiesResp.testId, fetchedCapabilitiesResp.name);
+							if (fetchedTestName) {
+								ctx.testIdTestNameMap?.set(fetchedCapabilitiesResp.testId, fetchedTestName);
 							}
 							ctx.log.debug(`Cached LTMS fallback testId for sessionId ${sessionId}: ${fetchedCapabilitiesResp.testId}`);
 						}