diff --git a/src/org/labkey/test/tests/AbstractAssayTest.java b/src/org/labkey/test/tests/AbstractAssayTest.java index 931a79c331..e65c4d7c70 100644 --- a/src/org/labkey/test/tests/AbstractAssayTest.java +++ b/src/org/labkey/test/tests/AbstractAssayTest.java @@ -193,8 +193,11 @@ protected void setupEnvironment() _containerHelper.createProject(getProjectName(), null); goToProjectHome(getProjectName()); - // Some test use a stand alone specimen file. Before the file can be imported the Specimen module needs to be enabled. - _containerHelper.enableModule("Specimen"); + if (_studyHelper.isSpecimenModulePresent()) + { + // Some test use a stand alone specimen file. Before the file can be imported the Specimen module needs to be enabled. + _containerHelper.enableModule("Specimen"); + } log("Setting up groups, users and initial permissions"); ApiPermissionsHelper permissionsHelper = new ApiPermissionsHelper(this); diff --git a/src/org/labkey/test/tests/AliquotTest.java b/src/org/labkey/test/tests/AliquotTest.java index 3a95f168fe..dc37cf1367 100644 --- a/src/org/labkey/test/tests/AliquotTest.java +++ b/src/org/labkey/test/tests/AliquotTest.java @@ -21,7 +21,6 @@ import org.labkey.test.Locator; import org.labkey.test.Locators; import org.labkey.test.TestTimeoutException; -import org.labkey.test.categories.Daily; import org.labkey.test.categories.Specimen; import org.labkey.test.components.html.BootstrapMenu; import org.labkey.test.components.html.OptionSelect; @@ -32,7 +31,7 @@ import java.io.File; -@Category({Daily.class, Specimen.class}) +@Category({Specimen.class}) @BaseWebDriverTest.ClassTimeout(minutes = 8) public class AliquotTest extends SpecimenBaseTest { diff --git a/src/org/labkey/test/tests/SpecimenCustomizeTest.java b/src/org/labkey/test/tests/SpecimenCustomizeTest.java index d01a2a2710..7f380c6534 100644 --- a/src/org/labkey/test/tests/SpecimenCustomizeTest.java +++ b/src/org/labkey/test/tests/SpecimenCustomizeTest.java @@ -20,7 +20,6 @@ import org.labkey.test.BaseWebDriverTest; import org.labkey.test.Locator; import org.labkey.test.TestFileUtils; -import org.labkey.test.categories.Daily; import org.labkey.test.categories.Specimen; import org.labkey.test.components.CustomizeView; import org.labkey.test.components.DomainDesignerPage; @@ -38,7 +37,7 @@ import java.util.Arrays; import java.util.List; -@Category({Daily.class, Specimen.class}) +@Category({Specimen.class}) @BaseWebDriverTest.ClassTimeout(minutes = 7) public class SpecimenCustomizeTest extends SpecimenBaseTest { diff --git a/src/org/labkey/test/tests/SpecimenExportTest.java b/src/org/labkey/test/tests/SpecimenExportTest.java index b5d3633a7f..0e334bebd9 100644 --- a/src/org/labkey/test/tests/SpecimenExportTest.java +++ b/src/org/labkey/test/tests/SpecimenExportTest.java @@ -20,7 +20,6 @@ import org.labkey.test.Locator; import org.labkey.test.TestFileUtils; import org.labkey.test.TestTimeoutException; -import org.labkey.test.categories.Daily; import org.labkey.test.categories.Specimen; import org.labkey.test.util.FileBrowserHelper; import org.labkey.test.util.LogMethod; @@ -30,7 +29,7 @@ import static org.junit.Assert.assertTrue; -@Category({Daily.class, Specimen.class}) +@Category({Specimen.class}) @BaseWebDriverTest.ClassTimeout(minutes = 6) public class SpecimenExportTest extends SpecimenBaseTest { diff --git a/src/org/labkey/test/tests/SpecimenGridExportTest.java b/src/org/labkey/test/tests/SpecimenGridExportTest.java index 89d7aab970..2c38160bb6 100644 --- a/src/org/labkey/test/tests/SpecimenGridExportTest.java +++ b/src/org/labkey/test/tests/SpecimenGridExportTest.java @@ -22,7 +22,6 @@ import org.labkey.test.Locator; import org.labkey.test.TestTimeoutException; import org.labkey.test.WebTestHelper; -import org.labkey.test.categories.Daily; import org.labkey.test.categories.Specimen; import org.labkey.test.util.AbstractDataRegionExportOrSignHelper.ColumnHeaderType; @@ -33,7 +32,7 @@ /** * Test exporting rows from a specimen grid (not folder/study specimen export.) */ -@Category({Daily.class, Specimen.class}) +@Category({Specimen.class}) @BaseWebDriverTest.ClassTimeout(minutes = 7) public class SpecimenGridExportTest extends AbstractExportTest { diff --git a/src/org/labkey/test/tests/SpecimenImportTest.java b/src/org/labkey/test/tests/SpecimenImportTest.java index 28f5d15837..04ae329a35 100644 --- a/src/org/labkey/test/tests/SpecimenImportTest.java +++ b/src/org/labkey/test/tests/SpecimenImportTest.java @@ -26,7 +26,6 @@ import org.labkey.test.BaseWebDriverTest; import org.labkey.test.Locator; import org.labkey.test.WebTestHelper; -import org.labkey.test.categories.Daily; import org.labkey.test.categories.Specimen; import org.labkey.test.components.ext4.RadioButton; import org.labkey.test.util.DataRegionTable; @@ -43,7 +42,7 @@ import static org.junit.Assert.assertEquals; -@Category({Daily.class, Specimen.class}) +@Category({Specimen.class}) @BaseWebDriverTest.ClassTimeout(minutes = 5) public class SpecimenImportTest extends SpecimenBaseTest { diff --git a/src/org/labkey/test/tests/SpecimenMultipleImportTest.java b/src/org/labkey/test/tests/SpecimenMultipleImportTest.java index 1fc06941ac..073c0bd5e6 100644 --- a/src/org/labkey/test/tests/SpecimenMultipleImportTest.java +++ b/src/org/labkey/test/tests/SpecimenMultipleImportTest.java @@ -19,14 +19,13 @@ import org.junit.experimental.categories.Category; import org.labkey.test.BaseWebDriverTest; import org.labkey.test.Locator; -import org.labkey.test.categories.Daily; import org.labkey.test.categories.Specimen; import org.labkey.test.util.LogMethod; import org.labkey.test.util.StudyHelper; import java.io.File; -@Category({Daily.class, Specimen.class}) +@Category({Specimen.class}) @BaseWebDriverTest.ClassTimeout(minutes = 6) public class SpecimenMultipleImportTest extends StudyBaseTest { diff --git a/src/org/labkey/test/tests/SpecimenTest.java b/src/org/labkey/test/tests/SpecimenTest.java index 6dea72c0af..0cbbc3af66 100644 --- a/src/org/labkey/test/tests/SpecimenTest.java +++ b/src/org/labkey/test/tests/SpecimenTest.java @@ -24,7 +24,6 @@ import org.labkey.test.Locators; import org.labkey.test.TestTimeoutException; import org.labkey.test.WebTestHelper; -import org.labkey.test.categories.Daily; import org.labkey.test.categories.Specimen; import org.labkey.test.components.CustomizeView; import org.labkey.test.components.dumbster.EmailRecordTable; @@ -59,7 +58,7 @@ import static org.labkey.test.pages.study.specimen.ManageNotificationsPage.SpecimensAttachment; import static org.labkey.test.util.DataRegionTable.DataRegion; -@Category({Daily.class, Specimen.class}) +@Category({Specimen.class}) @BaseWebDriverTest.ClassTimeout(minutes = 20) public class SpecimenTest extends SpecimenBaseTest { diff --git a/src/org/labkey/test/tests/StudyBaseTest.java b/src/org/labkey/test/tests/StudyBaseTest.java index db50748835..7dc92b47e5 100644 --- a/src/org/labkey/test/tests/StudyBaseTest.java +++ b/src/org/labkey/test/tests/StudyBaseTest.java @@ -58,6 +58,7 @@ public abstract class StudyBaseTest extends BaseWebDriverTest { protected static final File ARCHIVE_TEMP_DIR = StudyHelper.getStudyTempDir(); + protected int datasetCount = getDatasetCount(); protected int visitCount = 65; @@ -130,13 +131,19 @@ protected void startSpecimenImport(int completeJobsExpected) protected void startSpecimenImport(int completeJobsExpected, File specimenArchive) { - _specimenImporter = new SpecimenImporter(new File(StudyHelper.getStudySubfolderPath()), specimenArchive, ARCHIVE_TEMP_DIR, getFolderName(), completeJobsExpected); - _specimenImporter.startImport(); + if (_studyHelper.isSpecimenModulePresent()) + { + _specimenImporter = new SpecimenImporter(new File(StudyHelper.getStudySubfolderPath()), specimenArchive, ARCHIVE_TEMP_DIR, getFolderName(), completeJobsExpected); + _specimenImporter.startImport(); + } } protected void waitForSpecimenImport() { - _specimenImporter.waitForComplete(); + if (_studyHelper.isSpecimenModulePresent()) + { + _specimenImporter.waitForComplete(); + } } protected void setExpectSpecimenImportError(boolean expected) diff --git a/src/org/labkey/test/tests/TabTest.java b/src/org/labkey/test/tests/TabTest.java index dd086320a3..9f73d3482f 100644 --- a/src/org/labkey/test/tests/TabTest.java +++ b/src/org/labkey/test/tests/TabTest.java @@ -283,7 +283,8 @@ private void doTestContainerTabConversion() goToProjectHome(); _containerHelper.createSubfolder(getProjectName(), COLLAB_FOLDER, "Collaboration"); _containerHelper.createSubfolder(COLLABFOLDER_PATH, STUDY_FOLDER_TAB_NAME, "Study"); - _containerHelper.enableModule("Specimen"); + if (_studyHelper.isSpecimenModulePresent()) + _containerHelper.enableModule("Specimen"); _containerHelper.createSubfolder(COLLABFOLDER_PATH, ASSAY_FOLDER_TAB_NAME, "Assay"); clickFolder(COLLAB_FOLDER); clickFolder(STUDY_FOLDER_TAB_NAME); @@ -317,8 +318,11 @@ private void doTestContainerTabConversion() clickAndWait(Locator.linkWithText(STUDY_FOLDER_TAB_LABEL)); assertTextPresent("Study Overview"); studyContainerTab = PortalTab.finder(getDriver()).withTabText(STUDY_FOLDER_TAB_LABEL).find(); - studyContainerTab.goToTabContainer("Specimen Data"); - assertTextPresent("Vial Search", "Import Specimens"); + if (_studyHelper.isSpecimenModulePresent()) + { + studyContainerTab.goToTabContainer("Specimen Data"); + assertTextPresent("Vial Search", "Import Specimens"); + } clickAndWait(Locator.linkWithText(ASSAY_FOLDER_TAB_LABEL)); assertTextPresent("Assay List", EXTRA_ASSAY_WEBPART); @@ -343,8 +347,11 @@ private void doTestContainerTabConversion() assertTextPresent(STUDY_FOLDER_TAB_LABEL, ASSAY_FOLDER_TAB_LABEL); clickAndWait(Locator.linkWithText(STUDY_FOLDER_TAB_LABEL)); assertTextPresent("Study Overview"); - PortalTab.find(STUDY_FOLDER_TAB_LABEL, getDriver()).goToTabContainer("Specimen Data"); - assertTextPresent("Vial Search", "Import Specimens"); + if (_studyHelper.isSpecimenModulePresent()) + { + PortalTab.find(STUDY_FOLDER_TAB_LABEL, getDriver()).goToTabContainer("Specimen Data"); + assertTextPresent("Vial Search", "Import Specimens"); + } PortalTab.find(ASSAY_FOLDER_TAB_LABEL, getDriver()).activate(); assertTextPresent("Assay List", EXTRA_ASSAY_WEBPART); diff --git a/src/org/labkey/test/tests/flow/FlowSpecimenTest.java b/src/org/labkey/test/tests/flow/FlowSpecimenTest.java index 1ed3a6f657..ea0834002e 100644 --- a/src/org/labkey/test/tests/flow/FlowSpecimenTest.java +++ b/src/org/labkey/test/tests/flow/FlowSpecimenTest.java @@ -15,13 +15,13 @@ */ package org.labkey.test.tests.flow; +import org.junit.Assume; import org.junit.BeforeClass; import org.junit.Test; import org.junit.experimental.categories.Category; import org.labkey.test.BaseWebDriverTest; import org.labkey.test.Locator; import org.labkey.test.WebTestHelper; -import org.labkey.test.categories.Daily; import org.labkey.test.categories.Flow; import org.labkey.test.categories.Specimen; import org.labkey.test.components.assay.AssayConstants; @@ -38,7 +38,7 @@ /** * This test checks the flow specimen foreign key behavior from flow.FCSFiles and flow.FCSAnalyses. */ -@Category({Daily.class, Flow.class, Specimen.class}) +@Category({Flow.class, Specimen.class}) @BaseWebDriverTest.ClassTimeout(minutes = 8) public class FlowSpecimenTest extends BaseFlowTest { @@ -62,6 +62,7 @@ public static void initFlowFolders() @LogMethod private void initializeStudyFolder() { + Assume.assumeTrue("Specimen module not present", _studyHelper.isSpecimenModulePresent()); log("** Initialize Study Folder"); _containerHelper.createSubfolder(getProjectName(), getProjectName(), STUDY_FOLDER, "Study", null); _containerHelper.enableModule("Specimen"); diff --git a/src/org/labkey/test/tests/viability/AbstractViabilityTest.java b/src/org/labkey/test/tests/viability/AbstractViabilityTest.java index ebd119d6bb..3e78a6c1b7 100644 --- a/src/org/labkey/test/tests/viability/AbstractViabilityTest.java +++ b/src/org/labkey/test/tests/viability/AbstractViabilityTest.java @@ -70,7 +70,8 @@ protected void initializeStudyFolder(String... tabs) { log("** Initialize Folder"); _containerHelper.createProject(getProjectName(), null); - _containerHelper.enableModule("Specimen"); + if (_studyHelper.isSpecimenModulePresent()) + _containerHelper.enableModule("Specimen"); _containerHelper.createSubfolder(getProjectName(), getProjectName(), getFolderName(), "Study", tabs, true); log("** Create Study"); @@ -86,14 +87,17 @@ protected void importSpecimens() protected void importSpecimens(String studyFolder, File specimensPath) { - log("** Import specimens"); - clickFolder(studyFolder); - clickAndWait(Locator.linkWithText("Specimen Data")); - waitAndClickAndWait(Locator.linkWithText("Import Specimens")); - waitForElement(Locator.id("tsv")); - setFormElement(Locator.id("tsv"), TestFileUtils.getFileContents(specimensPath)); - submit(); - assertTextPresent("Specimens uploaded successfully"); + if (_studyHelper.isSpecimenModulePresent()) + { + log("** Import specimens"); + clickFolder(studyFolder); + clickAndWait(Locator.linkWithText("Specimen Data")); + waitAndClickAndWait(Locator.linkWithText("Import Specimens")); + waitForElement(Locator.id("tsv")); + setFormElement(Locator.id("tsv"), TestFileUtils.getFileContents(specimensPath)); + submit(); + assertTextPresent("Specimens uploaded successfully"); + } } protected void createViabilityAssay()