Skip to content

Clear some GitHub warnings; remove some dead code#7690

Open
labkey-jeckels wants to merge 1 commit into
developfrom
fb_githubWarnings
Open

Clear some GitHub warnings; remove some dead code#7690
labkey-jeckels wants to merge 1 commit into
developfrom
fb_githubWarnings

Conversation

@labkey-jeckels
Copy link
Copy Markdown
Contributor

Rationale

GitHub has some warnings for us

Changes

  • Set cookie attributes consistently
  • Delete dead code/arguments in PageFlowUtil/PopupMenu
  • Hide some more stack traces

Tasks 📍

  • Claude Code Review
  • Manual Testing
  • Test Automation

@labkey-jeckels labkey-jeckels added this to the 26.06 milestone May 23, 2026
@labkey-jeckels labkey-jeckels self-assigned this May 23, 2026
PrintWriter out = response.getWriter();
out.println("\"'>--></script><script type=\"text/javascript\" nonce=\"" + PageFlowUtil.filter(HttpView.currentPageConfig().getScriptNonce()) + "\">");
out.println("window.location = '" + PageFlowUtil.filter(url) + "';");
out.println("window.location = " + PageFlowUtil.jsString(url) + ";");
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants