Skip to content

URP scripts missing scripting define symbols containment #906

Description

@GuillaumeCauvet

Describe the bug 💬

Trying to import the package in a HDRP project I get a bunch of errors on script ;
RoughRefractionFeatureRenderGraph.cs

Library\PackageCache\org.khronos.unitygltf@ce6a5dce952d\Runtime\Scripts\RenderPipelines\RoughRefractionFeatureRenderGraph.cs(13,40): error CS0246: The type or namespace name 'ScriptableRendererFeature' could not be found (are you missing a using directive or an assembly reference?) Library\PackageCache\org.khronos.unitygltf@ce6a5dce952d\Runtime\Scripts\RenderPipelines\RoughRefractionFeatureRenderGraph.cs(12,3): error CS0246: The type or namespace name 'DisallowMultipleRendererFeatureAttribute' could not be found (are you missing a using directive or an assembly reference?) Library\PackageCache\org.khronos.unitygltf@ce6a5dce952d\Runtime\Scripts\RenderPipelines\RoughRefractionFeatureRenderGraph.cs(12,3): error CS0246: The type or namespace name 'DisallowMultipleRendererFeature' could not be found (are you missing a using directive or an assembly reference?) Library\PackageCache\org.khronos.unitygltf@ce6a5dce952d\Runtime\Scripts\RenderPipelines\RoughRefractionFeatureRenderGraph.cs(28,43): error CS0246: The type or namespace name 'ScriptableRenderer' could not be found (are you missing a using directive or an assembly reference?) Library\PackageCache\org.khronos.unitygltf@ce6a5dce952d\Runtime\Scripts\RenderPipelines\RoughRefractionFeatureRenderGraph.cs(28,76): error CS0246: The type or namespace name 'RenderingData' could not be found (are you missing a using directive or an assembly reference?) Library\PackageCache\org.khronos.unitygltf@ce6a5dce952d\Runtime\Scripts\RenderPipelines\RoughRefractionFeatureRenderGraph.cs(42,33): error CS0246: The type or namespace name 'ScriptableRenderPass' could not be found (are you missing a using directive or an assembly reference?)

These come from URP package references inside.

Looking at the assembly definition file and other scripts in that folder it appears that the script is missing HAVE_URP_[...] symbols meant to exclude it from compilation if URP is not present in the project.

Steps to reproduce 🔢

Create HDRP project and import package.

Files to reproduce the issue ♻

No response

Editor Version 🎲

Other (Provide details below)

Render Pipeline and version

6000.4 - HDRP

UnityGLTF Version

2.19.5

Operating System 👩‍💻

Windows

When does this problem happen?

  • Editor Import
  • Runtime Import
  • Editor Export
  • Runtime Export

Additional Info 📜

No response

Validations 🩹

Metadata

Metadata

Assignees

Labels

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions