Increase ETA update interval#147
Conversation
For what is worth, I find |
|
|
More on point about the PR, I think the "problem" is that buildkite seems to have a fancy terminal which does the live update thing. GitHub Actions doesn't do that at all, so the log is quite simple and readable. Maybe that's what you want to change, rather than the update interval? |
|
But also I don't think this needs to be customizable. Looking at the code, this updates every second or when it needs to. I assume the every second update is just for up to date timing info, which has minute-level resolution. Updating every second is probably way overkill and could be changed to something like 5 or 10 seconds without any noticeable difference? |
|
Okay I'm convinced just increasing the update interval is the best approach. I made it 20 seconds since this value really only matters when no tests are starting/ending and to for the ETA (rounded to the closest minute) so every 20 seconds is plenty often IMO |
It's also used to show the list of running jobs, no? That may change more frequently. I'm still of the idea that you don't want Buildkite to show the live data at all, that completely messes up the log anyway. |
The loop itself is run every 0.1 seconds, and if there are any changes to display it bypasses the 1s (on main) interval, so running tests should be handled by that path. At least they seem to be for me locally |
See discussion
Looking at https://buildkite.com/julialang/opencl-dot-jl/builds/1086/table?jid=019f6c40-f664-4ccd-a4e4-600ef1bf2e33&tab=output taking forever (probably #124), I noticed that the logs are currently 1.3MB purely because of status updates. This allows the update interval to be customized.Other potential approaches are auto detect CI and set it to 5 sec. Could also add an environment variable since this is geared towards CI