Drop the requirement for cluster managers to subtype ClusterManager#67
Open
JamesWrigley wants to merge 3 commits intomasterfrom
Open
Drop the requirement for cluster managers to subtype ClusterManager#67JamesWrigley wants to merge 3 commits intomasterfrom
ClusterManager#67JamesWrigley wants to merge 3 commits intomasterfrom
Conversation
This is explicitly marked as an internal function, it should never have been documented.
This should make it easier for existing Distributed cluster managers to add support for DistributedNext.
Due to the use of `import` our `connect()` was just adding a method to `Sockets.connect()`.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 88.81% 88.84% +0.03%
==========================================
Files 13 13
Lines 2271 2278 +7
==========================================
+ Hits 2017 2024 +7
Misses 254 254 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make it easier for existing Distributed cluster managers to add support for DistributedNext.