Fix highlighting regression from using Highlights.jl incorrectly - #415
Merged
Conversation
Member
|
I think we can use a release of TerminalRegressionTests now (my branch got deleted when I merged the PR) |
Collaborator
Author
|
See JuliaRegistries/General#162024. You forgot to release 0.3.0 so 0.3.1 didn't release sucessfully either. |
Member
Member
|
I guess someplace has been missed |
Collaborator
Author
|
you put it specifically in the CI script also |
Member
|
Yes, for 1.10..? |
Collaborator
Author
|
right. makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes regression caused by #390. @KristofferC's claude was right that using
:juliainstead oftree_sitter_julia_jllcaused the issue. Also, now that JuliaDocs/Highlights.jl#91 is merged and released, we can stop using a bunch of Highlights.jl internals and useHighlights.highlight.Also fixed TerminalRegressionTests source to use a a commit rather than a branch which has since been deleted.