Skip to content

Commit e71c19d

Browse files
clean up code and add a forgotten Test
1 parent aed43d8 commit e71c19d

17 files changed

Lines changed: 417 additions & 327 deletions

File tree

coverage/lcov-report/index.html

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -20,24 +20,24 @@ <h1>
2020
</h1>
2121
<div class='clearfix'>
2222
<div class='fl pad1y space-right2'>
23-
<span class="strong">93.63% </span>
23+
<span class="strong">93.6% </span>
2424
<span class="quiet">Statements</span>
25-
<span class='fraction'>147/157</span>
25+
<span class='fraction'>190/203</span>
2626
</div>
2727
<div class='fl pad1y space-right2'>
28-
<span class="strong">78% </span>
28+
<span class="strong">75.81% </span>
2929
<span class="quiet">Branches</span>
30-
<span class='fraction'>39/50</span>
30+
<span class='fraction'>47/62</span>
3131
</div>
3232
<div class='fl pad1y space-right2'>
33-
<span class="strong">96% </span>
33+
<span class="strong">100% </span>
3434
<span class="quiet">Functions</span>
35-
<span class='fraction'>24/25</span>
35+
<span class='fraction'>34/34</span>
3636
</div>
3737
<div class='fl pad1y space-right2'>
38-
<span class="strong">93.63% </span>
38+
<span class="strong">97.41% </span>
3939
<span class="quiet">Lines</span>
40-
<span class='fraction'>147/157</span>
40+
<span class='fraction'>188/193</span>
4141
</div>
4242
</div>
4343
<p class="quiet">
@@ -63,15 +63,15 @@ <h1>
6363
</thead>
6464
<tbody><tr>
6565
<td class="file high" data-value="src"><a href="src\index.html">src</a></td>
66-
<td data-value="98.08" class="pic high"><div class="chart"><div class="cover-fill" style="width: 98%;"></div><div class="cover-empty" style="width:2%;"></div></div></td>
67-
<td data-value="98.08" class="pct high">98.08%</td>
68-
<td data-value="52" class="abs high">51/52</td>
66+
<td data-value="98.31" class="pic high"><div class="chart"><div class="cover-fill" style="width: 98%;"></div><div class="cover-empty" style="width:2%;"></div></div></td>
67+
<td data-value="98.31" class="pct high">98.31%</td>
68+
<td data-value="59" class="abs high">58/59</td>
6969
<td data-value="50" class="pct medium">50%</td>
7070
<td data-value="6" class="abs medium">3/6</td>
7171
<td data-value="100" class="pct high">100%</td>
72-
<td data-value="6" class="abs high">6/6</td>
73-
<td data-value="98.08" class="pct high">98.08%</td>
74-
<td data-value="52" class="abs high">51/52</td>
72+
<td data-value="7" class="abs high">7/7</td>
73+
<td data-value="98.31" class="pct high">98.31%</td>
74+
<td data-value="59" class="abs high">58/59</td>
7575
</tr>
7676

7777
<tr>
@@ -89,28 +89,28 @@ <h1>
8989

9090
<tr>
9191
<td class="file high" data-value="src/models"><a href="src\models\index.html">src/models</a></td>
92-
<td data-value="91.67" class="pic high"><div class="chart"><div class="cover-fill" style="width: 91%;"></div><div class="cover-empty" style="width:9%;"></div></div></td>
93-
<td data-value="91.67" class="pct high">91.67%</td>
94-
<td data-value="48" class="abs high">44/48</td>
95-
<td data-value="66.67" class="pct medium">66.67%</td>
96-
<td data-value="12" class="abs medium">8/12</td>
92+
<td data-value="94.12" class="pic high"><div class="chart"><div class="cover-fill" style="width: 94%;"></div><div class="cover-empty" style="width:6%;"></div></div></td>
93+
<td data-value="94.12" class="pct high">94.12%</td>
94+
<td data-value="51" class="abs high">48/51</td>
95+
<td data-value="75" class="pct medium">75%</td>
96+
<td data-value="12" class="abs medium">9/12</td>
9797
<td data-value="100" class="pct high">100%</td>
9898
<td data-value="8" class="abs high">8/8</td>
99-
<td data-value="91.67" class="pct high">91.67%</td>
100-
<td data-value="48" class="abs high">44/48</td>
99+
<td data-value="94.12" class="pct high">94.12%</td>
100+
<td data-value="51" class="abs high">48/51</td>
101101
</tr>
102102

103103
<tr>
104104
<td class="file high" data-value="src/routes"><a href="src\routes\index.html">src/routes</a></td>
105-
<td data-value="89.13" class="pic high"><div class="chart"><div class="cover-fill" style="width: 89%;"></div><div class="cover-empty" style="width:11%;"></div></div></td>
106-
<td data-value="89.13" class="pct high">89.13%</td>
107-
<td data-value="46" class="abs high">41/46</td>
108-
<td data-value="82.61" class="pct high">82.61%</td>
109-
<td data-value="23" class="abs high">19/23</td>
110-
<td data-value="88.89" class="pct high">88.89%</td>
111-
<td data-value="9" class="abs high">8/9</td>
112-
<td data-value="89.13" class="pct high">89.13%</td>
113-
<td data-value="46" class="abs high">41/46</td>
105+
<td data-value="89.02" class="pic high"><div class="chart"><div class="cover-fill" style="width: 89%;"></div><div class="cover-empty" style="width:11%;"></div></div></td>
106+
<td data-value="89.02" class="pct high">89.02%</td>
107+
<td data-value="82" class="abs high">73/82</td>
108+
<td data-value="74.29" class="pct medium">74.29%</td>
109+
<td data-value="35" class="abs medium">26/35</td>
110+
<td data-value="100" class="pct high">100%</td>
111+
<td data-value="17" class="abs high">17/17</td>
112+
<td data-value="98.61" class="pct high">98.61%</td>
113+
<td data-value="72" class="abs high">71/72</td>
114114
</tr>
115115

116116
</tbody>
@@ -119,7 +119,7 @@ <h1>
119119
</div><!-- /wrapper -->
120120
<div class='footer quiet pad2 space-top1 center small'>
121121
Code coverage
122-
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Wed Mar 21 2018 14:58:13 GMT-0500 (Central Daylight Time)
122+
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Fri Mar 23 2018 13:43:07 GMT-0500 (Central Daylight Time)
123123
</div>
124124
</div>
125125
<script src="prettify.js"></script>

coverage/lcov-report/src/app.js.html

Lines changed: 22 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ <h1>
2020
</h1>
2121
<div class='clearfix'>
2222
<div class='fl pad1y space-right2'>
23-
<span class="strong">97.96% </span>
23+
<span class="strong">98% </span>
2424
<span class="quiet">Statements</span>
25-
<span class='fraction'>48/49</span>
25+
<span class='fraction'>49/50</span>
2626
</div>
2727
<div class='fl pad1y space-right2'>
2828
<span class="strong">50% </span>
@@ -35,9 +35,9 @@ <h1>
3535
<span class='fraction'>6/6</span>
3636
</div>
3737
<div class='fl pad1y space-right2'>
38-
<span class="strong">97.96% </span>
38+
<span class="strong">98% </span>
3939
<span class="quiet">Lines</span>
40-
<span class='fraction'>48/49</span>
40+
<span class='fraction'>49/50</span>
4141
</div>
4242
</div>
4343
<p class="quiet">
@@ -145,7 +145,9 @@ <h1>
145145
<a name='L97'></a><a href='#L97'>97</a>
146146
<a name='L98'></a><a href='#L98'>98</a>
147147
<a name='L99'></a><a href='#L99'>99</a>
148-
<a name='L100'></a><a href='#L100'>100</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">1x</span>
148+
<a name='L100'></a><a href='#L100'>100</a>
149+
<a name='L101'></a><a href='#L101'>101</a>
150+
<a name='L102'></a><a href='#L102'>102</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">1x</span>
149151
<span class="cline-any cline-yes">1x</span>
150152
<span class="cline-any cline-yes">1x</span>
151153
<span class="cline-any cline-yes">1x</span>
@@ -163,15 +165,15 @@ <h1>
163165
<span class="cline-any cline-yes">1x</span>
164166
<span class="cline-any cline-yes">1x</span>
165167
<span class="cline-any cline-neutral">&nbsp;</span>
166-
<span class="cline-any cline-neutral">&nbsp;</span>
167-
<span class="cline-any cline-neutral">&nbsp;</span>
168168
<span class="cline-any cline-yes">1x</span>
169169
<span class="cline-any cline-yes">1x</span>
170170
<span class="cline-any cline-yes">1x</span>
171171
<span class="cline-any cline-neutral">&nbsp;</span>
172172
<span class="cline-any cline-neutral">&nbsp;</span>
173173
<span class="cline-any cline-neutral">&nbsp;</span>
174174
<span class="cline-any cline-neutral">&nbsp;</span>
175+
<span class="cline-any cline-neutral">&nbsp;</span>
176+
<span class="cline-any cline-neutral">&nbsp;</span>
175177
<span class="cline-any cline-yes">1x</span>
176178
<span class="cline-any cline-neutral">&nbsp;</span>
177179
<span class="cline-any cline-yes">1x</span>
@@ -192,6 +194,8 @@ <h1>
192194
<span class="cline-any cline-yes">1x</span>
193195
<span class="cline-any cline-yes">1x</span>
194196
<span class="cline-any cline-neutral">&nbsp;</span>
197+
<span class="cline-any cline-yes">1x</span>
198+
<span class="cline-any cline-neutral">&nbsp;</span>
195199
<span class="cline-any cline-neutral">&nbsp;</span>
196200
<span class="cline-any cline-neutral">&nbsp;</span>
197201
<span class="cline-any cline-neutral">&nbsp;</span>
@@ -235,12 +239,12 @@ <h1>
235239
<span class="cline-any cline-neutral">&nbsp;</span>
236240
<span class="cline-any cline-yes">1x</span>
237241
<span class="cline-any cline-neutral">&nbsp;</span>
238-
<span class="cline-any cline-yes">15x</span>
239-
<span class="cline-any cline-yes">15x</span>
242+
<span class="cline-any cline-yes">21x</span>
243+
<span class="cline-any cline-yes">21x</span>
240244
<span class="cline-any cline-neutral">&nbsp;</span>
241-
<span class="cline-any cline-yes">15x</span>
245+
<span class="cline-any cline-yes">21x</span>
242246
<span class="cline-any cline-neutral">&nbsp;</span>
243-
<span class="cline-any cline-yes">15x</span>
247+
<span class="cline-any cline-yes">21x</span>
244248
<span class="cline-any cline-neutral">&nbsp;</span>
245249
<span class="cline-any cline-neutral">&nbsp;</span>
246250
<span class="cline-any cline-neutral">&nbsp;</span>
@@ -262,12 +266,12 @@ <h1>
262266
const config = require('config');
263267
const dbConfig = config.get('DBHost');
264268
&nbsp;
265-
&nbsp;
266-
&nbsp;
267-
const index = require('./routes/index');
269+
const course = require('./routes/course');
268270
const user = require('./routes/user');
269271
const app = express();
270272
&nbsp;
273+
//process.setMaxListeners(11);
274+
&nbsp;
271275
//const env = process.env.NODE_ENV || 'dev';
272276
&nbsp;
273277
//mongoDb Connection
@@ -290,6 +294,8 @@ <h1>
290294
// Callback to populate DB once collections have been cleared
291295
seeder.populateModels(data, function() {
292296
console.log("Finished seeding Database!");
297+
&nbsp;
298+
app.emit("appStarted"); //Emits an event to tell our tests it is ok to now test.
293299
});
294300
});
295301
});
@@ -321,7 +327,7 @@ <h1>
321327
app.use(cookieParser());
322328
app.use(express.static(path.join(__dirname, 'public')));
323329
&nbsp;
324-
app.use('/', index);
330+
app.use('/api/courses', course);
325331
app.use('/api/users', user);
326332
&nbsp;
327333
// catch 404 and forward to error handler
@@ -349,7 +355,7 @@ <h1>
349355
</div><!-- /wrapper -->
350356
<div class='footer quiet pad2 space-top1 center small'>
351357
Code coverage
352-
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Wed Mar 21 2018 14:58:13 GMT-0500 (Central Daylight Time)
358+
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Fri Mar 23 2018 13:43:07 GMT-0500 (Central Daylight Time)
353359
</div>
354360
</div>
355361
<script src="..\prettify.js"></script>

coverage/lcov-report/src/index.html

Lines changed: 26 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ <h1>
2020
</h1>
2121
<div class='clearfix'>
2222
<div class='fl pad1y space-right2'>
23-
<span class="strong">98.08% </span>
23+
<span class="strong">98.31% </span>
2424
<span class="quiet">Statements</span>
25-
<span class='fraction'>51/52</span>
25+
<span class='fraction'>58/59</span>
2626
</div>
2727
<div class='fl pad1y space-right2'>
2828
<span class="strong">50% </span>
@@ -32,12 +32,12 @@ <h1>
3232
<div class='fl pad1y space-right2'>
3333
<span class="strong">100% </span>
3434
<span class="quiet">Functions</span>
35-
<span class='fraction'>6/6</span>
35+
<span class='fraction'>7/7</span>
3636
</div>
3737
<div class='fl pad1y space-right2'>
38-
<span class="strong">98.08% </span>
38+
<span class="strong">98.31% </span>
3939
<span class="quiet">Lines</span>
40-
<span class='fraction'>51/52</span>
40+
<span class='fraction'>58/59</span>
4141
</div>
4242
</div>
4343
<p class="quiet">
@@ -63,28 +63,41 @@ <h1>
6363
</thead>
6464
<tbody><tr>
6565
<td class="file high" data-value="app.js"><a href="app.js.html">app.js</a></td>
66-
<td data-value="97.96" class="pic high"><div class="chart"><div class="cover-fill" style="width: 97%;"></div><div class="cover-empty" style="width:3%;"></div></div></td>
67-
<td data-value="97.96" class="pct high">97.96%</td>
68-
<td data-value="49" class="abs high">48/49</td>
66+
<td data-value="98" class="pic high"><div class="chart"><div class="cover-fill" style="width: 98%;"></div><div class="cover-empty" style="width:2%;"></div></div></td>
67+
<td data-value="98" class="pct high">98%</td>
68+
<td data-value="50" class="abs high">49/50</td>
6969
<td data-value="50" class="pct medium">50%</td>
7070
<td data-value="6" class="abs medium">3/6</td>
7171
<td data-value="100" class="pct high">100%</td>
7272
<td data-value="6" class="abs high">6/6</td>
73-
<td data-value="97.96" class="pct high">97.96%</td>
74-
<td data-value="49" class="abs high">48/49</td>
73+
<td data-value="98" class="pct high">98%</td>
74+
<td data-value="50" class="abs high">49/50</td>
75+
</tr>
76+
77+
<tr>
78+
<td class="file high" data-value="finishSeed.js"><a href="finishSeed.js.html">finishSeed.js</a></td>
79+
<td data-value="100" class="pic high"><div class="chart"><div class="cover-fill cover-full" style="width: 100%;"></div><div class="cover-empty" style="width:0%;"></div></div></td>
80+
<td data-value="100" class="pct high">100%</td>
81+
<td data-value="4" class="abs high">4/4</td>
82+
<td data-value="100" class="pct high">100%</td>
83+
<td data-value="0" class="abs high">0/0</td>
84+
<td data-value="100" class="pct high">100%</td>
85+
<td data-value="1" class="abs high">1/1</td>
86+
<td data-value="100" class="pct high">100%</td>
87+
<td data-value="4" class="abs high">4/4</td>
7588
</tr>
7689

7790
<tr>
7891
<td class="file high" data-value="utils.js"><a href="utils.js.html">utils.js</a></td>
7992
<td data-value="100" class="pic high"><div class="chart"><div class="cover-fill cover-full" style="width: 100%;"></div><div class="cover-empty" style="width:0%;"></div></div></td>
8093
<td data-value="100" class="pct high">100%</td>
81-
<td data-value="3" class="abs high">3/3</td>
94+
<td data-value="5" class="abs high">5/5</td>
8295
<td data-value="100" class="pct high">100%</td>
8396
<td data-value="0" class="abs high">0/0</td>
8497
<td data-value="100" class="pct high">100%</td>
8598
<td data-value="0" class="abs high">0/0</td>
8699
<td data-value="100" class="pct high">100%</td>
87-
<td data-value="3" class="abs high">3/3</td>
100+
<td data-value="5" class="abs high">5/5</td>
88101
</tr>
89102

90103
</tbody>
@@ -93,7 +106,7 @@ <h1>
93106
</div><!-- /wrapper -->
94107
<div class='footer quiet pad2 space-top1 center small'>
95108
Code coverage
96-
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Wed Mar 21 2018 14:58:13 GMT-0500 (Central Daylight Time)
109+
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Fri Mar 23 2018 13:43:07 GMT-0500 (Central Daylight Time)
97110
</div>
98111
</div>
99112
<script src="..\prettify.js"></script>

coverage/lcov-report/src/middleware/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ <h1>
8080
</div><!-- /wrapper -->
8181
<div class='footer quiet pad2 space-top1 center small'>
8282
Code coverage
83-
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Wed Mar 21 2018 14:58:13 GMT-0500 (Central Daylight Time)
83+
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Fri Mar 23 2018 13:43:07 GMT-0500 (Central Daylight Time)
8484
</div>
8585
</div>
8686
<script src="..\..\prettify.js"></script>

coverage/lcov-report/src/middleware/index.js.html

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -67,16 +67,16 @@ <h1>
6767
<span class="cline-any cline-yes">1x</span>
6868
<span class="cline-any cline-neutral">&nbsp;</span>
6969
<span class="cline-any cline-neutral">&nbsp;</span>
70-
<span class="cline-any cline-yes">3x</span>
71-
<span class="cline-any cline-yes">3x</span>
70+
<span class="cline-any cline-yes">16x</span>
71+
<span class="cline-any cline-yes">16x</span>
7272
<span class="cline-any cline-yes">1x</span>
7373
<span class="cline-any cline-neutral">&nbsp;</span>
74-
<span class="cline-any cline-yes">2x</span>
75-
<span class="cline-any cline-yes">2x</span>
76-
<span class="cline-any cline-yes">1x</span>
74+
<span class="cline-any cline-yes">15x</span>
75+
<span class="cline-any cline-yes">15x</span>
76+
<span class="cline-any cline-yes">4x</span>
7777
<span class="cline-any cline-neutral">&nbsp;</span>
78-
<span class="cline-any cline-yes">1x</span>
79-
<span class="cline-any cline-yes">1x</span>
78+
<span class="cline-any cline-yes">11x</span>
79+
<span class="cline-any cline-yes">11x</span>
8080
<span class="cline-any cline-neutral">&nbsp;</span>
8181
<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">const auth = require('basic-auth');
8282
const User = require('../models/user');
@@ -100,7 +100,7 @@ <h1>
100100
</div><!-- /wrapper -->
101101
<div class='footer quiet pad2 space-top1 center small'>
102102
Code coverage
103-
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Wed Mar 21 2018 14:58:13 GMT-0500 (Central Daylight Time)
103+
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Fri Mar 23 2018 13:43:07 GMT-0500 (Central Daylight Time)
104104
</div>
105105
</div>
106106
<script src="..\..\prettify.js"></script>

0 commit comments

Comments
 (0)