Skip to content

Commit 71de8e6

Browse files
Added config to project
1 parent 92aec4a commit 71de8e6

7 files changed

Lines changed: 54 additions & 13 deletions

File tree

config/development.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"DBHost": "mongodb://localhost:27017/TeamTreeHouseProject11"
3+
}

config/production.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"DBHost": "mongodb://mongo:27017/TeamTreeHouseProject11"
3+
}

config/test.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"DBHost": "mongodb://localhost:27017/TeamTreeHouseProject11Test"
3+
}

package-lock.json

Lines changed: 16 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
"scripts": {
77
"babel-node": "babel-node --presets=es2015",
88
"nodemon": "nodemon -e pug,js,css --exec npm run babel-node -- src/bin/www",
9-
"start": "npm run nodemon",
10-
"test": "mocha --compilers js:babel-register --recursive ./test/"
9+
"start": "SET NODE_ENV=dev && npm run nodemon",
10+
"test": "mocha --timeout 10000 --compilers js:babel-register --recursive ./test/"
1111
},
1212
"author": "",
1313
"license": "ISC",
@@ -24,6 +24,7 @@
2424
"dependencies": {
2525
"bcrypt": "^1.0.3",
2626
"body-parser": "~1.18.2",
27+
"config": "^1.30.0",
2728
"cookie-parser": "~1.4.3",
2829
"debug": "~2.6.9",
2930
"express": "~4.15.5",

src/app.js

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,21 +11,24 @@ const User = require('./models/user');
1111
const Course = require('./models/course');
1212
const Review = require('./models/review');
1313

14+
console.log(process.env.NODE_ENV);
15+
const config = require('config');
16+
const dbConfig = config.get('DBHost');
17+
18+
console.log(dbConfig);
19+
1420

1521
const index = require('./routes/index');
1622
const app = express();
1723

18-
const dbName = 'TeamTreeHouseProject11';
19-
20-
const env = process.env.NODE_ENV || 'dev';
24+
//const env = process.env.NODE_ENV || 'dev';
2125

2226
//mongoDb Connection
23-
if(env ==='dev' || env ==='development'){
24-
mongoose.connect('mongodb://localhost:27017/'+dbName );
25-
}
26-
else{
27-
mongoose.connect('mongodb://mongo:27017/'+dbName);
28-
}
27+
mongoose.connect(dbConfig);
28+
29+
30+
31+
2932
const db = mongoose.connection;
3033
db.on('error', console.error.bind(console, 'connection error:'));
3134

@@ -35,7 +38,7 @@ db.on('connected', function() {
3538

3639

3740

38-
seeder.connect('mongodb://localhost:27017/'+dbName, function(){
41+
seeder.connect(dbConfig, function(){
3942
// Load Mongoose models
4043
seeder.loadModels([
4144
'./src/models/user',
@@ -62,7 +65,10 @@ app.set('view engine', 'pug');
6265

6366
// uncomment after placing your favicon in /public
6467
//app.use(favicon(path.join(__dirname, 'public', 'favicon.ico')));
65-
app.use(logger('dev'));
68+
69+
if(config.util.getEnv('NODE_ENV') !== 'test') {
70+
app.use(logger('dev'));
71+
}
6672
app.use(bodyParser.json());
6773
app.use(bodyParser.urlencoded({ extended: false }));
6874
app.use(cookieParser());

test/test.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,18 @@
11
'use strict';
2+
process.env.NODE_ENV = 'test';
3+
24

35
import { expect } from 'chai'
46

7+
8+
59
describe('test', function () {
610
it('should pass', function () {
711
expect('string').to.be.a('string')
812
});
13+
14+
15+
it('should set NODE_ENV to equal test', () => {
16+
expect(process.env.NODE_ENV).to.be.equal('test');
17+
});
918
});

0 commit comments

Comments
 (0)