Skip to content

Commit 21afe88

Browse files
modified user get test to exclude hashed password
1 parent 12954ef commit 21afe88

3 files changed

Lines changed: 41 additions & 21 deletions

File tree

src/middleware/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ const auth = require('basic-auth');
22
const User = require('../models/user');
33
import Utils from '../utils';
44

5-
65
export function authorizeUser(req, res, next) {
76
let user = auth(req);
87
if(!user || !user.name || !user.pass){

src/routes/user.js

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,24 @@ const User = require('../models/user');
44
import {authorizeUser} from "../middleware/index";
55
import Utils from '../utils';
66

7-
/* GET home page. */
8-
router.get('/', authorizeUser, (req, res) => {
9-
// if(!req.session || !req.session.userId){
10-
// Utils.throwError()
11-
// }
12-
// User.findById(req.session.userId)
13-
let status = 200;
14-
res.status(status).json({success: true, message: "User Successfully retrieved", status: status});
7+
/* GET Routes */
8+
router.get('/', authorizeUser, (req, res, next) => {
9+
if(!req.session || !req.session.userId){
10+
return Utils.throwError(401, "Invalid or missing SessionId", next);
11+
}
12+
User.findById(req.session.userId)
13+
.exec((error, user) => {
14+
if(error){
15+
return next(error);
16+
}
17+
let status = 200;
18+
res.status(status).json({success: true, message: "User Successfully retrieved", status: status, user: user});
19+
});
1520
});
1621

17-
22+
/*
23+
Post Routes
24+
*/
1825
router.post('/', (req, res, next) => {
1926
if(!req.body.emailAddress || !req.body.fullName || !req.body.password){
2027
return Utils.throwError(422, "Missing Parameters", next);

test/user_test.js

Lines changed: 25 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ describe('Users', () => {
2020
chai.request(server)
2121
.get(getAPI)
2222
.end((err, res) => {
23-
res.should.have.status(401);
24-
res.body.should.have.property('success').equal(false);
25-
res.body.should.have.property('message').equal("Access Denied: Please supply login credentials!");
26-
done();
23+
res.should.have.status(401);
24+
res.body.should.have.property('success').equal(false);
25+
res.body.should.have.property('message').equal("Access Denied: Please supply login credentials!");
26+
done();
2727
});
2828
});
2929
it('should not GET if auth headers supplied are invalid', (done) => {
@@ -35,21 +35,33 @@ describe('Users', () => {
3535
});
3636

3737
it('should GET if auth headers are present', (done) => {
38+
let user = {
39+
_id: "57029ed4795118be119cc437",
40+
fullName: "Joe Smith",
41+
emailAddress: "joe@smith.com",
42+
__v: 0
43+
};
44+
3845
let auth = {
3946
user: 'joe@smith.com',
4047
pass: 'password'
4148
};
42-
getAuthRequest(auth, 200, true, "User Successfully retrieved", done);
49+
getAuthRequest(auth, 200, true, "User Successfully retrieved", done, user);
4350
});
4451

45-
function getAuthRequest(auth, status, success, msg, done){
52+
function getAuthRequest(auth, status, success, msg, done, user) {
4653
chai.request(server)
4754
.get(getAPI)
4855
.auth(auth.user, auth.pass)
4956
.end((err, res) => {
5057
res.should.have.status(status);
5158
res.body.should.have.property('success').equal(success);
5259
res.body.should.have.property('message').equal(msg);
60+
if(user){
61+
res.body.should.have.property('user').property('fullName').equal(user.fullName);
62+
res.body.should.have.property('user').property('emailAddress').equal(user.emailAddress);
63+
res.body.should.have.property('user').property('_id').equal(user._id);
64+
}
5365
done();
5466
});
5567
}
@@ -94,9 +106,9 @@ describe('Users', () => {
94106
.post(postAPI)
95107
.send(user)
96108
.end((err, res) => {
97-
res.body.should.have.property('message').equal("User Already Exists");
98-
res.should.have.status(409); //Conflict error
99-
done();
109+
res.body.should.have.property('message').equal("User Already Exists");
110+
res.should.have.status(409); //Conflict error
111+
done();
100112
});
101113
});
102114
});
@@ -126,7 +138,8 @@ describe('Users', () => {
126138
};
127139
postUser(user, done);
128140
});
129-
function postUser(user, done){
141+
142+
function postUser(user, done) {
130143
chai.request(server)
131144
.post(postAPI)
132145
.send(user)
@@ -136,7 +149,8 @@ describe('Users', () => {
136149
done();
137150
});
138151
}
139-
function postUser400(user, done ) {
152+
153+
function postUser400(user, done) {
140154
chai.request(server)
141155
.post(postAPI)
142156
.send(user)

0 commit comments

Comments
 (0)