Explode Assembly seems to be broken?

[0x007E]

Currently for me it is not possible to explode drawings with Freecad 0.21.1 (Win). If i use an older version of ExplodeAssembly there are no problems. The following error message appears:

09:35:08  Exploded Assembly workbench loaded
09:35:10  Running the Python command 'GoToEnd' failed:
Traceback (most recent call last):
  File "C:\Users\ragae\AppData\Roaming\FreeCAD\Mod\ExplodedAssembly\EAInit.py", line 315, in Activated
    ea.goToEnd()
  File "C:\Users\ragae\AppData\Roaming\FreeCAD\Mod\ExplodedAssembly\ExplodedAssembly.py", line 450, in goToEnd
    obj_base = traj.dir_vectors[n]*inc_D

can't multiply sequence by non-int of type 'float'

Maybe it is due the setup of AnimationStepTime?

I didn´t test if the problems are comming from there but if the code was changed to only accept int it would be necessary to change all my project. I haven´t checked the code of the last commit but possible this is a #bug?

[s-light]

https://github.com/JMG1/ExplodedAssembly/blame/master/ExplodedAssembly.py#L450
At least ther was sonething chabged exactky in this line...

[JMG1]

I am not able to reproduce the error, could you post a file with the issue at the FreeCAD forum?

[0x007E]

@JMG1 -> You can use the mechanical.FCStd template from this repository. Message is still the same:

09:27:33  Exploded Assembly workbench loaded
09:27:37  Running the Python command 'GoToEnd' failed:
Traceback (most recent call last):
  File "C:\Users\***\AppData\Roaming\FreeCAD\Mod\ExplodedAssembly\EAInit.py", line 315, in Activated
    ea.goToEnd()
  File "C:\Users\***\AppData\Roaming\FreeCAD\Mod\ExplodedAssembly\ExplodedAssembly.py", line 450, in goToEnd
    obj_base = traj.dir_vectors[n]*inc_D

can't multiply sequence by non-int of type 'float'

FreeCAD Version:

[code]
OS: Windows 10 build 19045
Word size of FreeCAD: 64-bit
Version: 0.21.1.33668 +26 (Git)
Build type: Release
Branch: (HEAD detached at 0.21.1)
Hash: f6708547a9bb3f71a4aaade12109f511a72c207c
Python 3.8.10, Qt 5.15.2, Coin 4.0.1, Vtk 8.2.0, OCC 7.6.3
Locale: German/Austria (de_AT)
Installed mods: 
  * ExplodedAssembly
  * fasteners 0.5.12
  * kicadStepUpMod 10.23.2
  * ThreadProfile 1.89.0
[/code]

Installed version of ExplodeAssembly

Unknown -> Installed. This is the latest version available for branch master.

With another computer, where the same version of FreeCAD is installed but an older version of ExplodeAssembly it is no problem and everything is working as expected.

[hoedur]

The same problem also occurs with this file: TigarDen.FCStd.

Tbh, I did not put much effort into an analysis myself, but let Claude analyze it. Result: thie following diff leads to a working 'Exploded Assembly' without any Python exceptions:

  diff --git a/ExplodedAssembly.py b/ExplodedAssembly.py
  index 1111111..2222222 100644
  --- a/ExplodedAssembly.py
  +++ b/ExplodedAssembly.py
  @@ -447,9 +447,9 @@ def goToEnd():
           inc_R = traj.Revolutions / float(1)
           for n in range(len(objects)):
               obj = objects[n]
  -            obj_base = traj.dir_vectors[n]*inc_D
  -            obj_rot = FreeCAD.Rotation(traj.rot_vectors[n], inc_R*360)
  -            obj_rot_center = traj.rot_centers[n]
  +            obj_base = FreeCAD.Vector(tuple(traj.dir_vectors[n]))*inc_D
  +            obj_rot = FreeCAD.Rotation(FreeCAD.Vector(tuple(traj.rot_vectors[n])), inc_R*360)
  +            obj_rot_center = FreeCAD.Vector(tuple(traj.rot_centers[n]))
               incremental_placement = FreeCAD.Placement(obj_base, obj_rot, obj_rot_center)
               obj.Placement = incremental_placement.multiply(obj.Placement)

It boils down to a few incorrect type conversions. The above three lines seemingly (!) get them right. Needs verification by the author of this plugin.