Checklist
Describe the bug
Hello,
I noticed a couple of bypasses/gaps in the channel blocking feature (Settings -> Filter -> Filter by Channel) and have implemented the fixes across the submodules.
The Bugs
- Search Bypass: When a channel is blocked, its channel icon (
ChannelInfoItem) and playlists (PlaylistInfoItem) still show up in search results.
- Navigation Bypass: Clicking a blocked channel icon or a playlist from a blocked channel still opens the page and allows the user to watch the blocked content.
The Fixes
I have fixed these bugs and submitted two pull requests:
- PipePipeExtractor PR: Extends the
applyBlocking() filtering logic to also remove ChannelInfoItem and PlaylistInfoItem belonging to blocked channels.
- PipePipeClient PR: Adds navigation guards to
BaseListFragment and ChannelFragment to block navigating to blocked channels/playlists (showing a toast message instead).
Here are the PR links:
Please let me know what you think!
Version
v5.2.1-beta6
Frequency
Always (100% of the time)
Device
No response
Steps to reproduce the bug
No response
Additional context
No response
Checklist
Describe the bug
Hello,
I noticed a couple of bypasses/gaps in the channel blocking feature (Settings -> Filter -> Filter by Channel) and have implemented the fixes across the submodules.
The Bugs
ChannelInfoItem) and playlists (PlaylistInfoItem) still show up in search results.The Fixes
I have fixed these bugs and submitted two pull requests:
applyBlocking()filtering logic to also removeChannelInfoItemandPlaylistInfoItembelonging to blocked channels.BaseListFragmentandChannelFragmentto block navigating to blocked channels/playlists (showing a toast message instead).Here are the PR links:
Please let me know what you think!
Version
v5.2.1-beta6
Frequency
Always (100% of the time)
Device
No response
Steps to reproduce the bug
No response
Additional context
No response