Re-implement field write api from #506, but template view directly (no auto in function parameter)#523
Open
aliemen wants to merge 1 commit into
Open
Re-implement field write api from #506, but template view directly (no auto in function parameter)#523aliemen wants to merge 1 commit into
auto in function parameter)#523aliemen wants to merge 1 commit into
Conversation
…o auto in parameter)
Collaborator
Author
|
Looks like Jülich CI passes now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See description of #506.
I want to re-run the jülrich ci and see if this was actually the problem. Here is what I changed. From this:
to this:
I think that the Jülich
cuda/12.6+gcc/13combination didn't like this one. Newercudaversions don't seem to have a problem with that (that's why the cscs ci passed).