Skip to content

27 open PRs contain ~9 duplicate/superseded submissions — needs triage before merging #34

Description

@dmchaledev

Problem

The repo currently has 27 open PRs (as of 2026-07-01), almost all authored against asm/openapi.yaml, sat/openapi.yaml, or docs/index.html. A pass over the titles/diffs shows the same fixes were independently implemented multiple times, plus at least two PRs that are now stale because the same change already landed on main via a different PR. Merging any one PR in a cluster will put the others into conflict or make them redundant, and reviewer time is being spent evaluating N near-identical diffs instead of 1.

Duplicate / overlapping clusters

Theme PRs Notes
ASM Tags CRUD (GET/PATCH/DELETE /tags/{tag_id}) #3, #11, #22, #24 Four independent implementations of the same three endpoints. #22 and #24 are both full (GET+PATCH+DELETE) and based on the same commit (757d6e5) — they will conflict with each other.
ASM 403 Forbidden response coverage #5, #9, #14, #20 Four PRs adding the same response to the same endpoints.
ASM 429/rate-limit documentation #23 (headers only), #26 (429 responses), #31 (429 responses + headers) #31 looks like a superset of #23 + #26.
OpenAPI 3.0 nullable: true → 3.1 type-union syntax #4, #18 Same mechanical fix done twice.
Docs page Open Graph / Twitter / canonical meta tags #13, #25, #32 Three independent implementations touching docs/index.html.
ASM response examples / descriptions #7, #17, #28 Overlapping scope ("add response examples", "fix missing descriptions") — needs a diff comparison to confirm exact overlap.

Stale PRs (already superseded by main)

Suggested fix

  1. For each cluster, pick the most complete/recent PR, merge it, and close the rest with a comment pointing to the survivor (Closing as duplicate of #NN).
  2. Close feat: add SAT OpenAPI 3.1 spec #6 and feat: add SAT OpenAPI 3.1 specification #8 outright — superseded by the already-merged sat/openapi.yaml.
  3. Verify and likely close fix: pin Redoc CDN to @2 instead of @latest #12 — appears already covered by 72a5ab9 on main.
  4. To prevent recurrence: since these PRs are opened by an automated contributor (dmchaledev / Claude Code sessions), add a step (e.g. a CONTRIBUTING.md note or a pre-flight check in whatever triggers these runs) requiring a check of existing open PRs/issues touching the same file before starting new work.

Impact

Without triage, whichever PR in each cluster merges first will silently break the others (merge conflicts on asm/openapi.yaml/sat/openapi.yaml), and reviewers are currently facing ~3-4x the actual number of distinct changes to evaluate.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions