Skip to content

Commit f244e0e

Browse files
committed
Update Iterables.
1 parent 1efa43f commit f244e0e

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

kilo-client/src/main/java/org/httprpc/kilo/util/Iterables.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ public static <T, U extends Comparable<? super U>> Predicate<? super T> whereEqu
266266
* The comparison predicate.
267267
*/
268268
public static <T, U extends Comparable<? super U>> Predicate<? super T> whereNotEqualTo(Function<? super T, U> transform, U value) {
269-
return whereEqualTo(transform, value).negate();
269+
return element -> element != null && transform.apply(element).compareTo(value) != 0;
270270
}
271271

272272
/**
@@ -495,7 +495,7 @@ public static <T> Predicate<? super T> whereTrue(Function<? super T, Boolean> tr
495495
* The comparison predicate.
496496
*/
497497
public static <T> Predicate<? super T> whereFalse(Function<? super T, Boolean> transform) {
498-
return whereTrue(transform).negate();
498+
return element -> element != null && !transform.apply(element);
499499
}
500500

501501
/**

kilo-client/src/test/java/org/httprpc/kilo/util/IterablesTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,9 @@ public void testWhereEqualTo() {
135135
public void testWhereNotEqualTo() {
136136
var values = listOf("a", "ab", "abc", null);
137137

138-
var result = listOf(filter(values, whereNotEqualTo(String::length, 3))); // a, ab, null
138+
var result = listOf(filter(values, whereNotEqualTo(String::length, 3))); // a, ab
139139

140-
assertEquals(listOf("a", "ab", null), result);
140+
assertEquals(listOf("a", "ab"), result);
141141
}
142142

143143
@Test
@@ -225,9 +225,9 @@ public void testWhereTrue() {
225225
public void testWhereFalse() {
226226
var values = listOf(true, false, false, null);
227227

228-
var result = countOf(filter(values, whereFalse(Boolean::booleanValue))); // 3
228+
var result = countOf(filter(values, whereFalse(Boolean::booleanValue))); // 2
229229

230-
assertEquals(3, result);
230+
assertEquals(2, result);
231231
}
232232

233233
@Test

0 commit comments

Comments
 (0)