Automatically relocate package in Kotlin module files when moving packages

[elizarov]

Kotlin keeps additional package metadata in .kotlin_module files; however, these files are not adjusted automatically when relocate function of shadow plugin is used. This does not prevent proper usage of the resulting libraries at runtime, but can cause issues if you try to compile Kotlin code against libraries with such relocated packages, as Kotlin compiler uses this metadata to filter out packages.

There is a kotlinx-metadata-jvm library that can manipulate (read/write) Kotlin metadata, including .kotlin_module files. I can make a PR to support automatic package relocation in Kotlin metadata when relocate is used. Will you accept this sort of contribution?

[Goooler]

Good to see!

[johnrengelman]

@elizarov I'd be happy to take a look at a PR.
My gut is telling me that based on how complex that support is, that I might want to take this time to see if there is a way to have Shadow be extending in a way that makes adding this type of language specific support be added externally instead of in the main library. Would you be willing to work through that process? (My time is pretty small to work on this, so it could drag on, but if you're willing, we can try).

[DreierF]

FYI there is a plugin which supports this already on top of the shadow plugin: https://github.com/xpdustry/kotlin-shadow-relocator

But it would of course be nicer to have it work out-of-the-box 🙂

[Goooler]

Good to see! I'll push it to be bundled in this repo.

[Goooler]

I addressed the fix in #1539, but I have no idea how to test it. Reviews and suggestions are welcome!

[makeevrserg]

I addressed the fix in #1539, but I have no idea how to test it. Reviews and suggestions are welcome!

In issue #1622 I've provided sample project with kotlin's Exposed framework

I've tested with publishToMavenLocal and it seems, kotlin.Any still not found

And it's also seems, ShadowJar task became much slower

https://github.com/makeevrserg/ExposedGradleFail

[Goooler]

I'm fixing the Kotlin relocation stuff first, no priority to investigate your issue filed in #1622.

[makeevrserg]

I'm fixing the Kotlin relocation stuff first, no priority to investigate your issue filed in #1622.

Turns out, my issue is actually affected by relocation stuff. When repository's plugin applied kotlin-shadow-relocator, from which implementation and inspiration is taken, the problem is gone. But with #1539 it's still there

[Goooler]

Thanks for the investigation! I'll wait for some review feedback and then proceed with addressing the issue you reported.