Migrate device endpoints to generated models#6547
Draft
gpunto wants to merge 1 commit into
Draft
Conversation
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
464cbfc to
a91a64c
Compare
9048f69 to
32c54f4
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Goal
Migrate the
/devicesendpoints to generated models. Part of the incremental OpenAPI model migration.Built on top of the Serializer foundation PR (this is the first slice with a generated enum,
PushProvider).Part of AND-1291
Implementation
DeviceResponse,ListDevicesResponse, andCreateDeviceRequest(with the typedPushProvidersealed enum); delete the hand-writtenDeviceDto,DevicesResponse, andAddDeviceRequest.CreateDeviceRequest.PushProvider.PushProviderAdapter()inSerializer(the one-line-per-enum pattern the foundation enables).DeviceApi/MoshiChatApi/mappers at the generated types (real names, no aliases);Device.toDto()supplies placeholdercreatedAt/userId(required by the generated model, ignored by the server on upstream payloads).Testing
spotlessApply,apiDump(no API drift),lint,detekt, andtestDebugUnitTestall pass.addDevice(generated request +PushProviderenum) succeeds,getDevicesparses 22 realDeviceResponses (roundTrip=true),deleteDevicesucceeds.