Skip to content

Commit 3330f5e

Browse files
authored
docs(ci): note the check-approval gate on release PRs (#23)
v1.0.11 published and tagged fine, then its bump PR sat with no checks reported: GitHub held both runs as `action_required` because `github-actions[bot]` had no merged PR in the repo yet and the fork-PR approval policy was `first_time_contributors`. Auto-merge waits forever on checks that never report. Policy is now `first_time_contributors_new_to_github` and the bot has a merged PR, so it shouldn't come back. Documented anyway with the one command to clear it, since the symptom looks like a hung release rather than a permission prompt.
1 parent 6a8cbc5 commit 3330f5e

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

.github/workflows/release.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,17 @@ jobs:
8181
# has to arrive as a PR. Merge commit, not squash: the tag points at the
8282
# bump commit, and squashing would rewrite it and leave the tag off
8383
# master's history, which breaks the next release's changelog range.
84+
#
85+
# v1.0.11 needed its two check runs approved by hand before auto-merge
86+
# would fire. GitHub held them as `action_required` because
87+
# `github-actions[bot]` had no merged PR here yet and the fork-PR approval
88+
# policy was `first_time_contributors`. The policy is now
89+
# `first_time_contributors_new_to_github` and the bot has a merged PR, so
90+
# this shouldn't recur. If a release PR sits with no checks reported, that
91+
# is what happened: approve the runs on the Actions tab, or
92+
# `gh api -X POST repos/OWNER/REPO/actions/runs/RUN_ID/approve`.
93+
# npm, the tag and the GitHub release are already out at that point, so
94+
# only the bump on master is waiting.
8495
- name: Land the version bump on master
8596
if: ${{ !inputs.dry-run }}
8697
env:

0 commit comments

Comments
 (0)