refactor(davinci-client): simplify maxRepeatedCharacters and remove redundant casts

Author: ryanbas21

packages/davinci-client/src/lib/client.store.effects.ts

@@ -299,9 +299,9 @@ function continuePollingµ(
   mode: Extract<PollingMode, { _tag: 'continue' }>,
 ): Effect.Effect<PollingStatus, InternalErrorResponse> {
   if (mode.retriesRemaining <= 0) {
-    return Effect.succeed('timedOut' as PollingStatus);
+    return Effect.succeed('timedOut');
   }
-  return delayMs(mode.pollInterval).pipe(Effect.map(() => 'continue' as PollingStatus));
+  return delayMs(mode.pollInterval).pipe(Effect.map(() => 'continue'));
 }
 
 /**

packages/davinci-client/src/lib/password-policy.rules.ts

@@ -52,7 +52,7 @@ const maxRepeatedCharactersRule: PasswordPolicyRule = (policy, value) => {
   const maxCount = pipe(
     countChars(value),
     (counts) => Array.from(counts.values()),
-    Arr.reduce(0, (acc, n) => (n > acc ? n : acc)),
+    (values) => Math.max(0, ...values),
   );
   return maxCount > max ? [`Password cannot repeat any character more than ${max} times`] : [];
 };