Skip to content

Make parameter for SphinxQL->update() optional! #184

@KarelWintersky

Description

@KarelWintersky

Make parameter for 'update' method optional, because method replace have no required param:

public function replace()
    {
        $this->reset();
        $this->type = 'replace';

        return $this;
    }

usable as: $connection->replace()->into($index)->...

But:

public function update($index)
    {
        $this->reset();
        $this->type = 'update';
        $this->into($index);

        return $this;
    }

REQUIRES $index and can't be used same way

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions