Documentation Update Needed
Commit: b7c195e
Commit Message: fix: Update ArgoCD notifications configuration for context variables
What Changed
This commit introduces breaking changes to the ArgoCD notifications configuration structure:
-
Configuration Structure Change:
- Before: Flat fields
cluster-name and resource-group in the ConfigMap
- After: Nested
context object containing clusterName and resourceGroup
-
Setup Script Update:
- Modified
setup-cluster-name.sh to patch ConfigMap with new nested structure
- Changed from:
{"data":{"cluster-name":"...","resource-group":"..."}}
- Changed to:
{"data":{"context":"clusterName: ...\nresourceGroup: ...\n"}}
-
Template Variable Syntax:
- Changed from:
$cluster-name and $resource-group
- Changed to:
{{.context.clusterName}} and {{.context.resourceGroup}}
-
Safety Improvements:
- Added nil checks to triggers:
app.status.operationState != nil &&
- Prevents errors when status objects are not yet populated
Documentation Files to Update
Priority 1: Act-3/SETUP.md
- Section "Configure Cluster Name Context" (lines ~35-45) needs to be updated
- Current documentation shows the old flat structure
- Need to update the
kubectl patch command example to use the new nested context format
- Update all references from
clusterName to context.clusterName
Priority 2: Act-3/README.md
- Review and update any ArgoCD notifications configuration examples
- Ensure variable reference syntax is updated to use
{{.context.*}} format
Migration Notes Required
Users upgrading from the previous version need to:
- Re-run the
setup-cluster-name.sh script to migrate to the new format
- Or manually patch their ConfigMap with the new structure:
kubectl patch configmap argocd-notifications-cm -n argocd \
-p '{"data":{"context":"clusterName: YOUR_CLUSTER\nresourceGroup: YOUR_RG\n"}}'
- Restart the notifications controller after the change
Breaking Changes Alert
⚠️ This is a breaking change. Existing deployments using the old configuration format will need to update their ConfigMap structure or the notifications will fail to interpolate the cluster/resource group values correctly.
This issue was automatically created by analyzing commit b7c195e
Documentation Update Needed
Commit: b7c195e
Commit Message: fix: Update ArgoCD notifications configuration for context variables
What Changed
This commit introduces breaking changes to the ArgoCD notifications configuration structure:
Configuration Structure Change:
cluster-nameandresource-groupin the ConfigMapcontextobject containingclusterNameandresourceGroupSetup Script Update:
setup-cluster-name.shto patch ConfigMap with new nested structure{"data":{"cluster-name":"...","resource-group":"..."}}{"data":{"context":"clusterName: ...\nresourceGroup: ...\n"}}Template Variable Syntax:
$cluster-nameand$resource-group{{.context.clusterName}}and{{.context.resourceGroup}}Safety Improvements:
app.status.operationState != nil &&Documentation Files to Update
Priority 1: Act-3/SETUP.md
kubectl patchcommand example to use the new nested context formatclusterNametocontext.clusterNamePriority 2: Act-3/README.md
{{.context.*}}formatMigration Notes Required
Users upgrading from the previous version need to:
setup-cluster-name.shscript to migrate to the new formatkubectl patch configmap argocd-notifications-cm -n argocd \ -p '{"data":{"context":"clusterName: YOUR_CLUSTER\nresourceGroup: YOUR_RG\n"}}'Breaking Changes Alert
This issue was automatically created by analyzing commit b7c195e