Resolved issue with empty catch block

DearingDev · DearingDev · commit bde5fc8a7a70 · 2025-05-20T18:48:32.000-05:00
diff --git a/ModuleExplorer/functions/Show-ModuleCommandViewer.ps1 b/ModuleExplorer/functions/Show-ModuleCommandViewer.ps1
@@ -467,14 +467,21 @@ function Show-ModuleCommandViewer {
                         }
                         ([System.ConsoleKey]::RightArrow) {
                             if ($helpOptions[$currentHelpOptionIndex] -eq "Online") {
-                                try { Get-Help $currentCommandObjectForHelp.CommandInfo -Online } catch {}
+                                try { Get-Help $currentCommandObjectForHelp.CommandInfo -Online 
+                                } catch {
+                                    $currentHelpContentLines = "[red]Could not retrieve online help[/]"
+                                }
                                 $rightPaneView = 'HelpOptions'
                                 $currentHelpContentLines = @(); $helpContentScrollOffset = 0
                             }
                         }
                         ([System.ConsoleKey]::Enter) {
                             if ($helpOptions[$currentHelpOptionIndex] -eq "Online") {
-                                try { Get-Help $currentCommandObjectForHelp.CommandInfo -Online } catch {}
+                                try { Get-Help $currentCommandObjectForHelp.CommandInfo -Online 
+                                }
+                                catch {
+                                    $currentHelpContentLines = "[red]Could not retrieve online help[/]"
+                                }
                                 $rightPaneView = 'HelpOptions'
                                 $currentHelpContentLines = @(); $helpContentScrollOffset = 0
                             }

Original file line number	Diff line number	Diff line change
`@@ -467,14 +467,21 @@ function Show-ModuleCommandViewer {`
`467`	`467`	`}`
`468`	`468`	`([System.ConsoleKey]::RightArrow) {`
`469`	`469`	`if ($helpOptions[$currentHelpOptionIndex] -eq "Online") {`
`470`		`- try { Get-Help $currentCommandObjectForHelp.CommandInfo -Online } catch {}`
	`470`	`+ try { Get-Help $currentCommandObjectForHelp.CommandInfo -Online`
	`471`	`+ } catch {`
	`472`	`+ $currentHelpContentLines = "[red]Could not retrieve online help[/]"`
	`473`	`+ }`
`471`	`474`	`$rightPaneView = 'HelpOptions'`
`472`	`475`	`$currentHelpContentLines = @(); $helpContentScrollOffset = 0`
`473`	`476`	`}`
`474`	`477`	`}`
`475`	`478`	`([System.ConsoleKey]::Enter) {`
`476`	`479`	`if ($helpOptions[$currentHelpOptionIndex] -eq "Online") {`
`477`		`- try { Get-Help $currentCommandObjectForHelp.CommandInfo -Online } catch {}`
	`480`	`+ try { Get-Help $currentCommandObjectForHelp.CommandInfo -Online`
	`481`	`+ }`
	`482`	`+ catch {`
	`483`	`+ $currentHelpContentLines = "[red]Could not retrieve online help[/]"`
	`484`	`+ }`
`478`	`485`	`$rightPaneView = 'HelpOptions'`
`479`	`486`	`$currentHelpContentLines = @(); $helpContentScrollOffset = 0`
`480`	`487`	`}`