Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DIRAC/Core/Utilities/Subprocess.py
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@ def shellCall(timeout, cmdSeq, callbackFunction=None, env=None, bufferLimit=5242
result = shCall(timeout + 1)
else:
spObject = Subprocess(timeout, bufferLimit=bufferLimit)
result = spObject.systemCall(cmdSeq, callbackFunction=callbackFunction, env=env, shell=True)
result = spObject.systemCall(cmdSeq, callbackFunction=callbackFunction, env=env, shell=True) # nosec: B604
return result


Expand Down

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being removed as part of https://github.com/DIRACGrid/DIRAC/pull/8563/changes. I will wait for that one to be merged.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase now.

Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ def __readHostInfo():

# Disk occupancy
summary = ""
_status, output = subprocess.getstatusoutput("df")
_status, output = subprocess.getstatusoutput("df") # nosec: B605
lines = output.split("\n")
for i in range(len(lines)):
if lines[i].startswith("/dev"):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1604,7 +1604,7 @@ def run(self):
log.verbose("Cmd called", self.cmd)
output = self.spObject.systemCall(
self.cmd, env=self.exeEnv, callbackFunction=self.sendOutput, shell=True, start_new_session=True
)
) # nosec: B604
log.verbose(f"Output of system call within execution thread: {output}")
self.executionResults["Thread"] = output
timing = time.time() - start
Expand Down
Loading