From c2f8c0a072f2325c26e9b09f1560e837db297d02 Mon Sep 17 00:00:00 2001
From: seonghobae <8172694+seonghobae@users.noreply.github.com>
Date: Sun, 9 Aug 2026 09:33:46 +0000
Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=B9=20[code=20health]=20Extract=20exec?=
 =?UTF-8?q?ution=20logic=20in=20sandboxed=5Fverify.py=20main=20function?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

🎯 **What:** Extracted the inner try-except logic from main into a _execute_and_print_output function.
💡 **Why:** To reduce the length and cyclomatic complexity of main, improving readability and testability.
✅ **Verification:** Ran test suite, interrogate and bandit.
✨ **Result:** A much cleaner main function with separated execution concern.
---
 scripts/ci/sandboxed_verify.py | 49 +++++++++++++++++++---------------
 1 file changed, 27 insertions(+), 22 deletions(-)

diff --git a/scripts/ci/sandboxed_verify.py b/scripts/ci/sandboxed_verify.py
index aace18d45..e0ee93ae3 100644
--- a/scripts/ci/sandboxed_verify.py
+++ b/scripts/ci/sandboxed_verify.py
@@ -200,6 +200,32 @@ def emit_result(
     print(f"{RESULT_MARKER} {json.dumps(payload, sort_keys=True)}")
 
 
+def _execute_and_print_output(args: argparse.Namespace, copied_repo: Path, env: dict[str, str]) -> int:
+    """Execute the command and print stdout/stderr, returning the exit code."""
+    print(f"sandboxed-verify: cwd={copied_repo}")
+    print(f"sandboxed-verify: command={' '.join(args.command)}")
+    if args.allow_env:
+        print(f"sandboxed-verify: allowed env names={','.join(sorted(set(args.allow_env)))}")
+    if args.network != "default":
+        print(f"sandboxed-verify: network={args.network}")
+    try:
+        completed = run_command(args.command, copied_repo, env, args.timeout)
+        if completed.stdout:
+            print(completed.stdout, end="")
+        if completed.stderr:
+            print(completed.stderr, end="", file=sys.stderr)
+        return completed.returncode
+    except subprocess.TimeoutExpired as exc:
+        stdout = timeout_output_text(exc.stdout)
+        stderr = timeout_output_text(exc.stderr)
+        if stdout:
+            print(stdout, end="" if stdout.endswith("\n") else "\n")
+        if stderr:
+            print(stderr, end="" if stderr.endswith("\n") else "\n", file=sys.stderr)
+        print(f"sandboxed-verify: command timed out after {args.timeout}s", file=sys.stderr)
+        return 124
+
+
 def main(argv: Sequence[str] | None = None) -> int:
     """Run the CLI and return the verification command exit code."""
     args = parse_args(argv)
@@ -210,28 +236,7 @@ def main(argv: Sequence[str] | None = None) -> int:
     try:
         copied_repo = copy_workspace(Path(args.repo_root), sandbox, args.ignore)
         env = scrubbed_env(sandbox, args.allow_env)
-        print(f"sandboxed-verify: cwd={copied_repo}")
-        print(f"sandboxed-verify: command={' '.join(args.command)}")
-        if args.allow_env:
-            print(f"sandboxed-verify: allowed env names={','.join(sorted(set(args.allow_env)))}")
-        if args.network != "default":
-            print(f"sandboxed-verify: network={args.network}")
-        try:
-            completed = run_command(args.command, copied_repo, env, args.timeout)
-            if completed.stdout:
-                print(completed.stdout, end="")
-            if completed.stderr:
-                print(completed.stderr, end="", file=sys.stderr)
-            exit_code = completed.returncode
-        except subprocess.TimeoutExpired as exc:
-            stdout = timeout_output_text(exc.stdout)
-            stderr = timeout_output_text(exc.stderr)
-            if stdout:
-                print(stdout, end="" if stdout.endswith("\n") else "\n")
-            if stderr:
-                print(stderr, end="" if stderr.endswith("\n") else "\n", file=sys.stderr)
-            print(f"sandboxed-verify: command timed out after {args.timeout}s", file=sys.stderr)
-            exit_code = 124
+        exit_code = _execute_and_print_output(args, copied_repo, env)
         return exit_code
     finally:
         elapsed = time.monotonic() - start