tests: rewrite stale unit tests skipped by PR #250

[rubenvdlinde]

Context

PR #250 unblocked PHPUnit CI by marking three unit-test files skipped — the classes under test have all been refactored since the tests were written, so the existing test expectations no longer match the production code paths.

Files

• tests/Unit/EventListener/SoftwareCatalogEventListenerTest.php — SoftwareCatalogEventListener::handle() now dispatches via handleObjectCreated / handleObjectUpdated / handleObjectDeleted private methods, each resolving schema IDs via SettingsService and then calling the appropriate service method. Tests still assert the old handleNewContact / handleNewGebruiker / etc. direct service calls.
• tests/Unit/OrganisationUserWorkflowTest.php — ContactpersonenController's dependency surface has grown (additional collaborators) and ContactPersonHandler now has findByUuid and other methods the tests' mocks don't declare.
• tests/Unit/Service/ContactPersonHandlerTest.php — addUserToGroupWithCheck etc. now call IUserManager::get twice (lookup + verify) and the dependency surface includes new collaborators.

Re-do scope

For each file:

1. Read the current production code carefully.
2. Inventory current public methods + collaborators.
3. Rewrite tests against the new dispatch flow / call sequencing.
4. Remove the markTestSkipped shim from setUp.

Aim for the same coverage intent as the original tests (event routing, contact-conversion workflow, user-group membership management).

Tracked per user feedback rule 'Always file issues for deferred work'.

[muhammadshaharyaraulakh]

Thanks for the context on PR #250!

I'll take ownership of the test rewrite for all three files:

• SoftwareCatalogEventListenerTest.php
• OrganisationUserWorkflowTest.php
• ContactPersonHandlerTest.php

Plan:

1. Read the current production code for each class
2. Inventory public methods + collaborators
3. Rewrite tests against the new dispatch flow
4. Remove the markTestSkipped shim from setUp in each file

Would love a hand on this happy to pair on it or take a first pass and request review. Will keep the same coverage intent as the originals (event routing, contact-conversion workflow, user-group membership management).