You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Peptidoform objects with non-UNIMOD/PSI-MS modification names cannot be constructed under pyteomics 5, blocking a pyteomics 5 compatibility upgrade.
pyteomics 5 changed proforma.parse() to eagerly resolve modification names against UNIMOD and PSI-MS databases during parsing. Any name not found in a database raises KeyError instead of falling back to a GenericModification as in v4.
To reproduce:
frompsm_utilsimportPeptidoformPeptidoform("AC[Carbamidomethyl]DEK") # OK — name is in UNIMODPeptidoform("AC[Cmm]DEK") # KeyError: 'Cmm'Peptidoform("ACM[Oxidation (M)]EK") # KeyError: 'Oxidation (M)'
Peptidoformobjects with non-UNIMOD/PSI-MS modification names cannot be constructed under pyteomics 5, blocking a pyteomics 5 compatibility upgrade.pyteomics 5 changed
proforma.parse()to eagerly resolve modification names against UNIMOD and PSI-MS databases during parsing. Any name not found in a database raisesKeyErrorinstead of falling back to aGenericModificationas in v4.To reproduce:
Issues in practice:
io.maxquant: MaxQuant uses names likeOxidation (M)andAcetyl (Protein N-term)that are not valid UNIMOD terms and cannot be parsed under pyteomics 5. Also see Peptidoforms parsed from MaxQuant output are not always valid #138.Peptidoformwill break.For now, the Pyteomics dependency is capped to
< 5in psm_utils 1.5.5.