Make install.sh non-blocking if sudo password prompt fails and enhance install-cli.sh binary checks

Author: Coding-Meet

.agents/skills/library-insight/scripts/install-cli.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 # Check if library-insight is already available
-if command -v library-insight &> /dev/null; then
-    echo "library-insight is already installed and available on PATH."
+if command -v library-insight &> /dev/null || [ -x "$HOME/.library-insight/bin/library-insight" ]; then
+    echo "library-insight is already installed and ready to use."
     exit 0
 fi
 

install.sh

@@ -57,17 +57,27 @@ echo "Configuring executable permissions..."
 chmod +x "$INSTALL_DIR/bin/library-insight"
 
 echo "Creating global symlink..."
+SYMLINK_SUCCESS=false
 if [ -d "/usr/local/bin" ]; then
-    echo "Creating symlink in /usr/local/bin/library-insight (may request password for sudo)..."
-    sudo ln -sf "$INSTALL_DIR/bin/library-insight" /usr/local/bin/library-insight
+    if [ -w "/usr/local/bin" ]; then
+        ln -sf "$INSTALL_DIR/bin/library-insight" /usr/local/bin/library-insight 2>/dev/null && SYMLINK_SUCCESS=true
+    else
+        sudo -n ln -sf "$INSTALL_DIR/bin/library-insight" /usr/local/bin/library-insight 2>/dev/null && SYMLINK_SUCCESS=true || sudo ln -sf "$INSTALL_DIR/bin/library-insight" /usr/local/bin/library-insight 2>/dev/null && SYMLINK_SUCCESS=true || true
+    fi
+fi
+
+if [ "$SYMLINK_SUCCESS" = true ]; then
     echo "=================================================="
     echo " SUCCESS: Library Insight installed globally!"
     echo " You can now run the 'library-insight' command."
     echo "=================================================="
 else
-    echo "WARNING: /usr/local/bin does not exist on your system."
-    echo "Please add the following to your shell configuration (.zshrc or .bashrc):"
-    echo "  export PATH=\"\$PATH:$INSTALL_DIR/bin\""
+    echo "=================================================="
+    echo " SUCCESS: Library Insight installed at $INSTALL_DIR/bin/library-insight!"
+    echo " Direct path: $HOME/.library-insight/bin/library-insight"
+    echo " To run directly without full path, add this to your .zshrc / .bashrc:"
+    echo "   export PATH=\"\$PATH:$INSTALL_DIR/bin\""
+    echo "=================================================="
 fi
 
 echo ""

library-insight-cli/src/main/resources/scripts/install-cli.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 # Check if library-insight is already available
-if command -v library-insight &> /dev/null; then
-    echo "library-insight is already installed and available on PATH."
+if command -v library-insight &> /dev/null || [ -x "$HOME/.library-insight/bin/library-insight" ]; then
+    echo "library-insight is already installed and ready to use."
     exit 0
 fi