London | 25-SDC-July | Eyuel Abraham | Sprint 4 | Implementing cowsay#157

Open

eyuell21 wants to merge 4 commits into

CodeYourFuture:mainfrom

eyuell21:implementing-cowsay

eyuell21 commented Aug 8, 2025 •

edited

Loading

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Python implementation of Cowsay.

Questions

Ask any questions you have for your reviewer.

eyuell21 added 3 commits

August 2, 2025 12:43


          Added gitignore files.

5af07ad


          created a requirements.txt files including the libraries to be instal…

e448fe5

…led.


          Cowsay python implementation

96c0d12

eyuell21 added the Needs Review label

DaryaShirokova added Review in progress and removed Needs Review labels

DaryaShirokova reviewed

View reviewed changes

implement-cowsay/cow.py

+                  # Dynamically call the animal function (like cowsay.turtle("hello"))
+                  try:
+                      animal_func = getattr(cowsay, args.animal)

DaryaShirokova Aug 17, 2025

You can check out an alternative get_output_string method here to avoid getattr (not the best choice to use if there is alternative - it make code more readable).

eyuell21 Oct 15, 2025

Author

Noted, Thank you 🙏

implement-cowsay/cow.py Outdated

+                  try:
+                      animal_func = getattr(cowsay, args.animal)
+                      output = animal_func(message)
+                      print(output)

DaryaShirokova Aug 17, 2025

You program always prints none in the end, please debug why this is and fix (should be a simple fix :) )

DaryaShirokova added Reviewed and removed Review in progress labels


          Fix printing 'None' when cowsay animal functions print directly inste…

687e4d8

…ad of returning output

DaryaShirokova reviewed

View reviewed changes

implement-cowsay/cow.py

github-actions Bot commented Mar 3, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

4 similar comments

github-actions Bot commented Mar 3, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions Bot commented Mar 3, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions Bot commented Mar 3, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions Bot commented Mar 3, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

illicitonion added Complete and removed Reviewed labels

github-actions Bot commented Mar 4, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment

github-actions Bot commented Mar 4, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels