London | 26-ITP-May | Rizqah Popoola| Sprint 3 | Dead Code#1499
Open
risikatpopoola wants to merge 1 commit into
Open
London | 26-ITP-May | Rizqah Popoola| Sprint 3 | Dead Code#1499risikatpopoola wants to merge 1 commit into
risikatpopoola wants to merge 1 commit into
Conversation
risikatpopoola
added
🏕 Priority Mandatory
Poonam-raj
added
Review in progress
Poonam-raj
reviewed
Jul 14, 2026
| // The sayHello function should continue to work for any reasonable input it's given. | ||
|
|
||
| let testName = "Jerry"; | ||
| //let testName = "Jerry"; |
Contributor
There was a problem hiding this comment.
Instructions say to remove lines code that aren't used - please re-do, make sure you're deleting not needed lines
Poonam-raj
reviewed
Jul 14, 2026
|
|
||
| function sayHello(greeting, name) { | ||
| const greetingStr = greeting + ", " + name + "!"; | ||
| // const greetingStr = greeting + ", " + name + "!"; |
Contributor
There was a problem hiding this comment.
Same again, please remove
Poonam-raj
reviewed
Jul 14, 2026
Poonam-raj
left a comment
Poonam-raj
left a comment
Contributor
There was a problem hiding this comment.
Good work identifying the lines not needed - read instructions carefully and delete these before submitting.
Poonam-raj
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
redundant code commented out for the deadcode exercise