West Midlands | May 2026 | Muhammad-Burhan Mustafa | Sprint 2 | Module-Structuring-and-Testing-Data#1443
Open
burhan-mustafa wants to merge 19 commits into
Open
Conversation
burhan-mustafa
added
Needs Review
Liam310
added
Review in progress
Liam310
reviewed
Jul 7, 2026
Liam310
reviewed
Jul 7, 2026
Liam310
reviewed
Jul 7, 2026
Liam310
reviewed
Jul 7, 2026
Liam310
reviewed
Jul 7, 2026
|
|
||
| // =============> write your explanation here | ||
| // Since the parameter and variable have the same name, decimalNumber, we will get an error as we can not declare a | ||
| // variable of the same name with in the functions local scope |
There was a problem hiding this comment.
What's another problem with the original code?
Author
There was a problem hiding this comment.
answered that in the new changes : )
There was a problem hiding this comment.
Looks to me like you added another explanation for a problem.... in a different task! My question was in reference to the Sprint-2/1-key-errors/1.js problem. As well as the parameter having the same name as a local variable, there's another issue. What is it?
Author
There was a problem hiding this comment.
Whoopsies! I must have made a mistake out of exhaustion! I have properly answered it in this next commit
There was a problem hiding this comment.
So you are right about what you've written but it wasn't what I was thinking...
Specifically, what is the problem with the console.log on line 12?
Liam310
added
Reviewed
burhan-mustafa
added
Needs Review
Liam310
added
Reviewed
burhan-mustafa
added
Needs Review
Liam310
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
All tasks in sprint 2 completed.