Fix time formatting logic in formatAs12HourClock function; update test cases for accuracy

Author: JohnRob-jnr

Sprint-2/4-mandatory-interpret/time-format.js

@@ -26,13 +26,13 @@ function formatTimeDisplay(seconds) {
 // Call formatTimeDisplay with an input of 61, now answer the following:
 
 // b) What is the value assigned to num when pad is called for the first time?
-// =============> 1
+// =============> 0
 
 // c) What is the return value of pad is called for the first time?
-// =============> "01"
+// =============> 00
 
 // d) What is the value assigned to num when pad is called for the last time in this program?  Explain your answer
-// =============> write your answer here
+// =============> 1, the modulo  % operator means that 61 gives a remainder of 1
 
 // e) What is the return value of pad when it is called for the last time in this program?  Explain your answer
-// =============> write your answer here
+// =============> 01, this is so the 1 is padded with a leading 0 to make it 2 characters long. 

Sprint-2/5-stretch-extend/format-time.js

@@ -2,12 +2,24 @@
 // Make sure to do the prep before you do the coursework
 // Your task is to write tests for as many different groups of input data or edge cases as you can, and fix any bugs you find.
 
+const pad = (num) => String(num).padStart(2, "0");
+
 function formatAs12HourClock(time) {
   const hours = Number(time.slice(0, 2));
-  if (hours > 12) {
-    return `${hours - 12}:00 pm`;
+  const minutes = time.slice(3, 5);
+  
+  if (hours === 0) {
+    return `12:${minutes} am`;
+  }
+  else if (hours > 12) {
+    return `${pad(hours - 12)}:${minutes} pm`;
+  }
+  else if (hours === 12) {
+    return `${hours}:${minutes} pm`;
+  }
+  else {
+    return `${pad(hours)}:${minutes} am`;
   }
-  return `${time} am`;
 }
 
 const currentOutput = formatAs12HourClock("08:00");
@@ -25,14 +37,14 @@ console.assert(
 );
 
 const currentOutput3 = formatAs12HourClock("13:15");
-const targetOutput3 = "1:15 pm";
+const targetOutput3 = "01:15 pm";
 console.assert(
   currentOutput3 === targetOutput3,
   `current output: ${currentOutput3}, target output: ${targetOutput3}`
 );
 
 const currentOutput4 = formatAs12HourClock("12:00");
-const targetOutput4 = "12:00 am";
+const targetOutput4 = "12:00 pm";
 console.assert(
   currentOutput4 === targetOutput4,
   `current output: ${currentOutput4}, target output: ${targetOutput4}`