corrected and tested all my code

Author: Enice-Codes

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -14,22 +14,19 @@
 // Acceptance criteria:
 // After you have implemented the function, write tests to cover all the cases, and
 // execute the code to ensure all tests pass.
-
 function getAngleType(angle) {
-  // TODO: Implement this function
   if (angle > 0 && angle < 90)
-    return "Acute angle";
+    return "Acute angle";      
   else if (angle === 90)
-    return "Right angle";
+    return "right angle";      
   else if (angle > 90 && angle < 180)
-    return "obtuse angle";
+    return "obtuse angle";    
   else if (angle === 180)
-    return "Straight angle";
+    return "straight angle";   
   else if (angle > 180 && angle < 360)
-    return "Reflex angle";
+    return "reflex angle";     
   else
-    return "Invalid angle";
-
+    return "Invalid angle";    
 }
 
 // The line below allows us to load the getAngleType function into tests in other files.
@@ -48,7 +45,7 @@ function assertEquals(actualOutput, targetOutput) {
 // TODO: Write tests to cover all cases, including boundary and invalid cases.
 // Example: Identify Right Angles
 const right = getAngleType(90);
-assertEquals(right, "Right angle");
+assertEquals(right, "right angle");
 
 const acute = getAngleType(45);
 assertEquals(acute, 'Acute angle');
@@ -57,10 +54,10 @@ const obtuse = getAngleType(120);
 assertEquals(obtuse,'obtuse angle')
 
 const straight = getAngleType(180); 
-assertEquals(straight, 'Straight angle');
+assertEquals(straight, 'straight angle');
 
 const reflex = getAngleType(270);
-assertEquals(reflex, 'Reflex angle');
+assertEquals(reflex, 'reflex angle');
 
 const invalid1 = getAngleType(-10);
 assertEquals(invalid1, 'Invalid angle');

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -13,7 +13,7 @@
 function isProperFraction(numerator, denominator) {
   // TODO: Implement this function
   if (denominator === 0){
-    return fasle;
+    return false;
 
   }
   if (numerator < denominator && numerator > 0){
@@ -40,7 +40,7 @@ function assertEquals(actualOutput, targetOutput) {
 // Example: 1/2 is a proper fraction
 assertEquals(isProperFraction(1, 2), true);
 
-// exapmle : 4/3 is not a proper fraction
+// example: 4/3 is not a proper fraction
 assertEquals(isProperFraction(4, 3), false);
 
 // example: 6/5 is not a proper fraction

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -22,20 +22,21 @@
 // execute the code to ensure all tests pass.
 
 function getCardValue(card) {
-  // TODO: Implement this function
-  if(card === "A♠" || card === "A♥" || card === "A♦" || card === "A♣"){
-    return 11;
+  const rank = card.slice(0, -1); // everything except the last character (suit)
+  const validSuits = ["♠", "♥", "♦", "♣"];
+  const suit = card.slice(-1);
+
+  if (!validSuits.includes(suit)) {
+    throw new Error("Invalid card");
   }
-  else if(card === "J♠" || card === "J♥" || card === "J♦" || card === "J♣" || card === "Q♠" || card === "Q♥" || card === "Q♦" || card === "Q♣" || card === "K♠" || card === "K♥" || card === "K♦" || card === "K♣"){
+
+  if (rank === "A") {
+    return 11;
+  } else if (rank === "J" || rank === "Q" || rank === "K") {
     return 10;
-  }
-  else if(card === "2♠" || card === "2♥" || card === "2♦" || card === "2♣"){
-    return 2;
-  }
-  else if(card === "3♠" || card === "3♥" || card === "3♦" || card === "3♣"){
-    return 3;
-  }
-  else {
+  } else if (["2","3","4","5","6","7","8","9","10"].includes(rank)) {
+    return Number(rank);
+  } else {
     throw new Error("Invalid card");
   }
 }
@@ -74,11 +75,14 @@ assertEquals(getCardValue("2♠"), 2);
 assertEquals(getCardValue("3♥"), 3);
 
 // What other valid card cases can you think of?
-function assertEqual(func, valid message){
- try{
-  func();
-  console.log("Valid card test passed ");
- }
+function assertEqual(func, message) {
+  try {
+    func();
+    console.log("Valid card test passed: " + message);
+  } catch (e) {
+    console.error("Valid card test failed: " + message + " — " + e.message);
+  }
+}
 // What other invalid card cases can you think of?
  function  assertThrows(func, errorMessage) {
   try {

Sprint-3/2-practice-tdd/get-ordinal-number.js

@@ -1,5 +1,20 @@
 function getOrdinalNumber(num) {
-  return "1st";
+  const lastTwoDigits = num % 100;
+  const lastDigit = num % 10;
+
+  if (lastTwoDigits >= 11 && lastTwoDigits <= 13) {
+    return `${num}th`;
+  }
+
+  if (lastDigit === 1) {
+    return `${num}st`;
+  } else if (lastDigit === 2) {
+    return `${num}nd`;
+  } else if (lastDigit === 3) {
+    return `${num}rd`;
+  } else {
+    return `${num}th`;
+  }
 }
 
-module.exports = getOrdinalNumber;
+module.exports = getOrdinalNumber;